Re: [Qemu-devel] [PATCH v3] e1000: clean up phyreg_writeops/set_phy_ctrl

2014-07-02 Thread Michael S. Tsirkin
On Wed, Jul 02, 2014 at 12:12:30PM +0300, Michael S. Tsirkin wrote: > On Tue, Jul 01, 2014 at 03:03:48PM -0400, Gabriel L. Somlo wrote: > > Make phyreg_writeops responsible for actually writing their > > respective phy registers. The only current instance of > > phyreg_writeops is set_phy_ctrl(), w

Re: [Qemu-devel] [PATCH v3] e1000: clean up phyreg_writeops/set_phy_ctrl

2014-07-02 Thread Michael S. Tsirkin
On Tue, Jul 01, 2014 at 03:03:48PM -0400, Gabriel L. Somlo wrote: > Make phyreg_writeops responsible for actually writing their > respective phy registers. The only current instance of > phyreg_writeops is set_phy_ctrl(), which we modify to actually > write the register, while also correctly handli

[Qemu-devel] [PATCH v3] e1000: clean up phyreg_writeops/set_phy_ctrl

2014-07-01 Thread Gabriel L. Somlo
Make phyreg_writeops responsible for actually writing their respective phy registers. The only current instance of phyreg_writeops is set_phy_ctrl(), which we modify to actually write the register, while also correctly handling reserved and self-clearing bits. have_autoneg() does not need to check