Re: [Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-04-03 Thread Max Reitz
On 03.04.19 18:41, Max Reitz wrote: > On 01.04.19 09:21, Vladimir Sementsov-Ogievskiy wrote: >> 29.03.2019 22:32, Kevin Wolf wrote: >>> Am 29.03.2019 um 19:00 hat Vladimir Sementsov-Ogievskiy geschrieben: 29.03.2019 20:58, Vladimir Sementsov-Ogievskiy wrote: > 29.03.2019 20:44, Max Reitz w

Re: [Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-04-03 Thread Max Reitz
On 01.04.19 09:21, Vladimir Sementsov-Ogievskiy wrote: > 29.03.2019 22:32, Kevin Wolf wrote: >> Am 29.03.2019 um 19:00 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> 29.03.2019 20:58, Vladimir Sementsov-Ogievskiy wrote: 29.03.2019 20:44, Max Reitz wrote: > On 29.03.19 18:40, Kevin Wolf

Re: [Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-04-01 Thread Vladimir Sementsov-Ogievskiy
29.03.2019 22:32, Kevin Wolf wrote: > Am 29.03.2019 um 19:00 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 29.03.2019 20:58, Vladimir Sementsov-Ogievskiy wrote: >>> 29.03.2019 20:44, Max Reitz wrote: On 29.03.19 18:40, Kevin Wolf wrote: > Am 29.03.2019 um 18:30 hat Max Reitz geschrieben

Re: [Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-03-29 Thread Kevin Wolf
Am 29.03.2019 um 19:00 hat Vladimir Sementsov-Ogievskiy geschrieben: > 29.03.2019 20:58, Vladimir Sementsov-Ogievskiy wrote: > > 29.03.2019 20:44, Max Reitz wrote: > >> On 29.03.19 18:40, Kevin Wolf wrote: > >>> Am 29.03.2019 um 18:30 hat Max Reitz geschrieben: > On 29.03.19 18:24, Kevin Wolf

Re: [Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
29.03.2019 20:58, Vladimir Sementsov-Ogievskiy wrote: > 29.03.2019 20:44, Max Reitz wrote: >> On 29.03.19 18:40, Kevin Wolf wrote: >>> Am 29.03.2019 um 18:30 hat Max Reitz geschrieben: On 29.03.19 18:24, Kevin Wolf wrote: > Am 29.03.2019 um 18:15 hat Max Reitz geschrieben: >> On 29.03.

Re: [Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
29.03.2019 20:44, Max Reitz wrote: > On 29.03.19 18:40, Kevin Wolf wrote: >> Am 29.03.2019 um 18:30 hat Max Reitz geschrieben: >>> On 29.03.19 18:24, Kevin Wolf wrote: Am 29.03.2019 um 18:15 hat Max Reitz geschrieben: > On 29.03.19 12:04, Vladimir Sementsov-Ogievskiy wrote: >> bdrv_rep

Re: [Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-03-29 Thread Max Reitz
On 29.03.19 18:54, Vladimir Sementsov-Ogievskiy wrote: > 29.03.2019 20:39, Max Reitz wrote: >> On 29.03.19 18:31, Vladimir Sementsov-Ogievskiy wrote: >>> 29.03.2019 20:15, Max Reitz wrote: On 29.03.19 12:04, Vladimir Sementsov-Ogievskiy wrote: > bdrv_replace_child() calls bdrv_check_perm()

Re: [Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
29.03.2019 20:39, Max Reitz wrote: > On 29.03.19 18:31, Vladimir Sementsov-Ogievskiy wrote: >> 29.03.2019 20:15, Max Reitz wrote: >>> On 29.03.19 12:04, Vladimir Sementsov-Ogievskiy wrote: bdrv_replace_child() calls bdrv_check_perm() with error_abort on loosening permissions. However file

Re: [Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-03-29 Thread Max Reitz
On 29.03.19 18:40, Kevin Wolf wrote: > Am 29.03.2019 um 18:30 hat Max Reitz geschrieben: >> On 29.03.19 18:24, Kevin Wolf wrote: >>> Am 29.03.2019 um 18:15 hat Max Reitz geschrieben: On 29.03.19 12:04, Vladimir Sementsov-Ogievskiy wrote: > bdrv_replace_child() calls bdrv_check_perm() with

Re: [Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-03-29 Thread Kevin Wolf
Am 29.03.2019 um 18:30 hat Max Reitz geschrieben: > On 29.03.19 18:24, Kevin Wolf wrote: > > Am 29.03.2019 um 18:15 hat Max Reitz geschrieben: > >> On 29.03.19 12:04, Vladimir Sementsov-Ogievskiy wrote: > >>> bdrv_replace_child() calls bdrv_check_perm() with error_abort on > >>> loosening permissio

Re: [Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-03-29 Thread Max Reitz
On 29.03.19 18:31, Vladimir Sementsov-Ogievskiy wrote: > 29.03.2019 20:15, Max Reitz wrote: >> On 29.03.19 12:04, Vladimir Sementsov-Ogievskiy wrote: >>> bdrv_replace_child() calls bdrv_check_perm() with error_abort on >>> loosening permissions. However file-locking operations may fail even >>> in

Re: [Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
29.03.2019 20:30, Max Reitz wrote: > On 29.03.19 18:24, Kevin Wolf wrote: >> Am 29.03.2019 um 18:15 hat Max Reitz geschrieben: >>> On 29.03.19 12:04, Vladimir Sementsov-Ogievskiy wrote: bdrv_replace_child() calls bdrv_check_perm() with error_abort on loosening permissions. However file-lo

Re: [Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
29.03.2019 20:15, Max Reitz wrote: > On 29.03.19 12:04, Vladimir Sementsov-Ogievskiy wrote: >> bdrv_replace_child() calls bdrv_check_perm() with error_abort on >> loosening permissions. However file-locking operations may fail even >> in this case, for example on NFS. And this leads to Qemu crash.

Re: [Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-03-29 Thread Max Reitz
On 29.03.19 18:24, Kevin Wolf wrote: > Am 29.03.2019 um 18:15 hat Max Reitz geschrieben: >> On 29.03.19 12:04, Vladimir Sementsov-Ogievskiy wrote: >>> bdrv_replace_child() calls bdrv_check_perm() with error_abort on >>> loosening permissions. However file-locking operations may fail even >>> in thi

Re: [Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-03-29 Thread Kevin Wolf
Am 29.03.2019 um 18:15 hat Max Reitz geschrieben: > On 29.03.19 12:04, Vladimir Sementsov-Ogievskiy wrote: > > bdrv_replace_child() calls bdrv_check_perm() with error_abort on > > loosening permissions. However file-locking operations may fail even > > in this case, for example on NFS. And this lea

Re: [Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-03-29 Thread Max Reitz
On 29.03.19 12:04, Vladimir Sementsov-Ogievskiy wrote: > bdrv_replace_child() calls bdrv_check_perm() with error_abort on > loosening permissions. However file-locking operations may fail even > in this case, for example on NFS. And this leads to Qemu crash. > > Let's avoid such errors. Note, that

Re: [Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-03-29 Thread Kevin Wolf
Am 29.03.2019 um 12:04 hat Vladimir Sementsov-Ogievskiy geschrieben: > bdrv_replace_child() calls bdrv_check_perm() with error_abort on > loosening permissions. However file-locking operations may fail even > in this case, for example on NFS. And this leads to Qemu crash. > > Let's avoid such erro

[Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
bdrv_replace_child() calls bdrv_check_perm() with error_abort on loosening permissions. However file-locking operations may fail even in this case, for example on NFS. And this leads to Qemu crash. Let's avoid such errors. Note, that we ignore such things anyway on permission update commit and abo