Re: [Qemu-devel] [PATCH v3] Undefine SWP instruction unless SCTLR.SW bit is set

2012-04-17 Thread Peter Maydell
On 17 April 2012 14:11, Alexey Starikovskiy wrote: >> Adding this brace is incorrectly changing behaviour. >> (I agree that it's pretty obscure and halfway to being an >> outright bug. It all goes away with the cp15 rework anyway.) > Should I add tb_flush() without braces too or set second if() on

Re: [Qemu-devel] [PATCH v3] Undefine SWP instruction unless SCTLR.SW bit is set

2012-04-17 Thread Alexey Starikovskiy
> Adding this brace is incorrectly changing behaviour. > (I agree that it's pretty obscure and halfway to being an > outright bug. It all goes away with the cp15 rework anyway.) Should I add tb_flush() without braces too or set second if() only to avoid changing the bogus behavior? >> +            

Re: [Qemu-devel] [PATCH v3] Undefine SWP instruction unless SCTLR.SW bit is set

2012-04-17 Thread Peter Maydell
On 17 April 2012 13:50, Alexey Starikovskiy wrote: > ARM v7MP deprecates use of SWP instruction and only defines it > if OS explicitly requests it via setting SCTLR.SW bit. > Such a request is expected to occur only once during OS init, thus > only static checking for this bit and flush of all tra

[Qemu-devel] [PATCH v3] Undefine SWP instruction unless SCTLR.SW bit is set

2012-04-17 Thread Alexey Starikovskiy
ARM v7MP deprecates use of SWP instruction and only defines it if OS explicitly requests it via setting SCTLR.SW bit. Such a request is expected to occur only once during OS init, thus only static checking for this bit and flush of all translations is done on SCTLR change. Signed-off-by: Alexey St