Re: [Qemu-devel] [PATCH v3] Do not delete BlockDriverState when deleting the drive

2011-03-29 Thread Ryan Harper
* Markus Armbruster [2011-03-29 04:06]: > Since you have to respin anyway, would you mind limiting commit message > line length to 70-75 characters? Thanks. yep -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ry...@us.ibm.com

Re: [Qemu-devel] [PATCH v3] Do not delete BlockDriverState when deleting the drive

2011-03-29 Thread Ryan Harper
* Markus Armbruster [2011-03-29 02:44]: > Ryan Harper writes: > > > When removing a drive from the host-side via drive_del we currently have the > > following path: > > > > drive_del > > qemu_aio_flush() > > bdrv_close()// zaps bs->drv, which makes any subsequent I/O get > >

Re: [Qemu-devel] [PATCH v3] Do not delete BlockDriverState when deleting the drive

2011-03-29 Thread Markus Armbruster
Since you have to respin anyway, would you mind limiting commit message line length to 70-75 characters? Thanks.

Re: [Qemu-devel] [PATCH v3] Do not delete BlockDriverState when deleting the drive

2011-03-29 Thread Markus Armbruster
Ryan Harper writes: > When removing a drive from the host-side via drive_del we currently have the > following path: > > drive_del > qemu_aio_flush() > bdrv_close()// zaps bs->drv, which makes any subsequent I/O get > // dropped. Works as designed > drive_uninit() > bdrv_dele

[Qemu-devel] [PATCH v3] Do not delete BlockDriverState when deleting the drive

2011-03-28 Thread Ryan Harper
When removing a drive from the host-side via drive_del we currently have the following path: drive_del qemu_aio_flush() bdrv_close()// zaps bs->drv, which makes any subsequent I/O get // dropped. Works as designed drive_uninit() bdrv_delete() // frees the bs. Since the devi