Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState

2014-05-22 Thread Jeff Cody
On Wed, May 21, 2014 at 10:37:50PM +0800, Fam Zheng wrote: > On Wed, 05/21 10:24, Jeff Cody wrote: > > On Wed, May 21, 2014 at 04:03:03PM +0200, Stefan Hajnoczi wrote: > > > On Tue, May 20, 2014 at 02:04:31PM +0800, Fam Zheng wrote: > > > > diff --git a/block/mirror.c b/block/mirror.c > > > > index

Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState

2014-05-21 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Tue, May 20, 2014 at 02:04:31PM +0800, Fam Zheng wrote: >> This makes use of op_blocker and blocks all the operations except for >> commit target, on each BlockDriverState->backing_hd. >> >> The asserts for op_blocker in bdrv_swap are removed because with this >> cha

Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState

2014-05-21 Thread Fam Zheng
On Wed, 05/21 10:24, Jeff Cody wrote: > On Wed, May 21, 2014 at 04:03:03PM +0200, Stefan Hajnoczi wrote: > > On Tue, May 20, 2014 at 02:04:31PM +0800, Fam Zheng wrote: > > > diff --git a/block/mirror.c b/block/mirror.c > > > index 1c38aa8..6a53d79 100644 > > > --- a/block/mirror.c > > > +++ b/block

Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState

2014-05-21 Thread Jeff Cody
On Wed, May 21, 2014 at 04:03:03PM +0200, Stefan Hajnoczi wrote: > On Tue, May 20, 2014 at 02:04:31PM +0800, Fam Zheng wrote: > > diff --git a/block/mirror.c b/block/mirror.c > > index 1c38aa8..6a53d79 100644 > > --- a/block/mirror.c > > +++ b/block/mirror.c > > @@ -499,6 +499,7 @@ immediate_exit:

Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState

2014-05-21 Thread Stefan Hajnoczi
On Tue, May 20, 2014 at 02:04:31PM +0800, Fam Zheng wrote: > This makes use of op_blocker and blocks all the operations except for > commit target, on each BlockDriverState->backing_hd. > > The asserts for op_blocker in bdrv_swap are removed because with this > change, the target of block commit h

Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState

2014-05-21 Thread Stefan Hajnoczi
On Tue, May 20, 2014 at 02:04:31PM +0800, Fam Zheng wrote: > diff --git a/block/mirror.c b/block/mirror.c > index 1c38aa8..6a53d79 100644 > --- a/block/mirror.c > +++ b/block/mirror.c > @@ -499,6 +499,7 @@ immediate_exit: > * trigger the unref from the top one */ > BlockD

[Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState

2014-05-19 Thread Fam Zheng
This makes use of op_blocker and blocks all the operations except for commit target, on each BlockDriverState->backing_hd. The asserts for op_blocker in bdrv_swap are removed because with this change, the target of block commit has at least the backing blocker of its child, so the assertion is not