Re: [Qemu-devel] [PATCH v2 RESEND] pc: e820 qemu_cfg tables need to be packed

2010-11-16 Thread Anthony Liguori
On 11/05/2010 04:40 PM, Alex Williamson wrote: We can't let the compiler define the alignment for qemu_cfg data. Signed-off-by: Alex Williamson Applied. Thanks. Regards, Anthony Liguori --- hw/pc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pc.c

Re: [Qemu-devel] [PATCH v2 RESEND] pc: e820 qemu_cfg tables need to be packed

2010-11-10 Thread Alex Williamson
On Sun, 2010-11-07 at 14:59 +, Blue Swirl wrote: > On Fri, Nov 5, 2010 at 9:40 PM, Alex Williamson > wrote: > > We can't let the compiler define the alignment for qemu_cfg data. > > Actually, whole e820_table implementation seems to be buggy. The > structure may not be passed directly to fw_c

Re: [Qemu-devel] [PATCH v2 RESEND] pc: e820 qemu_cfg tables need to be packed

2010-11-07 Thread Blue Swirl
On Fri, Nov 5, 2010 at 9:40 PM, Alex Williamson wrote: > We can't let the compiler define the alignment for qemu_cfg data. Actually, whole e820_table implementation seems to be buggy. The structure may not be passed directly to fw_cfg interface without endianness conversions, otherwise the emulat

[Qemu-devel] [PATCH v2 RESEND] pc: e820 qemu_cfg tables need to be packed

2010-11-05 Thread Alex Williamson
We can't let the compiler define the alignment for qemu_cfg data. Signed-off-by: Alex Williamson --- hw/pc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 69b13bf..0264e3d 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -75,12 +75,12 @@ struct e820_en