Re: [Qemu-devel] [PATCH v2 7/9] hw/pvrdma: Delete unneeded function argument

2019-02-14 Thread Marcel Apfelbaum
On 2/13/19 4:46 PM, Yuval Shaia wrote: On Wed, Feb 13, 2019 at 01:40:34PM +0100, Philippe Mathieu-Daudé wrote: On 2/13/19 7:53 AM, Yuval Shaia wrote: The function argument rdma_dev_res is not needed as it is stored in the backend_dev object at init. Signed-off-by: Yuval Shaia Reviewed-by:

Re: [Qemu-devel] [PATCH v2 7/9] hw/pvrdma: Delete unneeded function argument

2019-02-13 Thread Eric Blake
On 2/13/19 6:40 AM, Philippe Mathieu-Daudé wrote: > On 2/13/19 7:53 AM, Yuval Shaia wrote: >> The function argument rdma_dev_res is not needed as it is stored in the >> backend_dev object at init. >> >> Signed-off-by: Yuval Shaia >> Reviewed-by: Marcel Apfelbaum > > Should we teach checkpatch.pl

Re: [Qemu-devel] [PATCH v2 7/9] hw/pvrdma: Delete unneeded function argument

2019-02-13 Thread Yuval Shaia
On Wed, Feb 13, 2019 at 01:40:34PM +0100, Philippe Mathieu-Daudé wrote: > On 2/13/19 7:53 AM, Yuval Shaia wrote: > > The function argument rdma_dev_res is not needed as it is stored in the > > backend_dev object at init. > > > > Signed-off-by: Yuval Shaia > > Reviewed-by: Marcel Apfelbaum > > Sh

Re: [Qemu-devel] [PATCH v2 7/9] hw/pvrdma: Delete unneeded function argument

2019-02-13 Thread Philippe Mathieu-Daudé
On 2/13/19 7:53 AM, Yuval Shaia wrote: > The function argument rdma_dev_res is not needed as it is stored in the > backend_dev object at init. > > Signed-off-by: Yuval Shaia > Reviewed-by: Marcel Apfelbaum Should we teach checkpatch.pl to check name/space/email?

[Qemu-devel] [PATCH v2 7/9] hw/pvrdma: Delete unneeded function argument

2019-02-12 Thread Yuval Shaia
The function argument rdma_dev_res is not needed as it is stored in the backend_dev object at init. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c | 13 ++--- hw/rdma/rdma_backend.h | 1 - hw/rdma/vmw/pvrdma_qp_ops.c | 3 +-- 3 files chang