Blue Swirl writes:
> On Tue, Jun 15, 2010 at 8:17 AM, Markus Armbruster wrote:
>> Blue Swirl writes:
>>
>>> On Mon, Jun 14, 2010 at 9:36 AM, Markus Armbruster
>>> wrote:
Blue Swirl writes:
> Make APICState completely private to apic.c by using DeviceState
> in external APIs
On Tue, Jun 15, 2010 at 8:17 AM, Markus Armbruster wrote:
> Blue Swirl writes:
>
>> On Mon, Jun 14, 2010 at 9:36 AM, Markus Armbruster wrote:
>>> Blue Swirl writes:
>>>
Make APICState completely private to apic.c by using DeviceState
in external APIs.
>>>
>>> Could you explain why thi
Blue Swirl writes:
> On Mon, Jun 14, 2010 at 9:36 AM, Markus Armbruster wrote:
>> Blue Swirl writes:
>>
>>> Make APICState completely private to apic.c by using DeviceState
>>> in external APIs.
>>
>> Could you explain why this is an improvement?
>
> Outside of apic.c, there is no need to acces
On Mon, Jun 14, 2010 at 9:36 AM, Markus Armbruster wrote:
> Blue Swirl writes:
>
>> Make APICState completely private to apic.c by using DeviceState
>> in external APIs.
>
> Could you explain why this is an improvement?
Outside of apic.c, there is no need to access APICState fields so we
can rem
Blue Swirl writes:
> Make APICState completely private to apic.c by using DeviceState
> in external APIs.
Could you explain why this is an improvement?
Make APICState completely private to apic.c by using DeviceState
in external APIs.
Move apic_init() to pc.c.
Signed-off-by: Blue Swirl
---
hw/apic.c | 86 +++-
hw/apic.h | 24 +++---
hw/pc.c | 32 +++
