Re: [Qemu-devel] [PATCH v2 6/6] target-arm: dump-guest-memory: add fpregset notes

2015-12-03 Thread Peter Maydell
On 3 December 2015 at 19:00, Andrew Jones wrote: > On Thu, Dec 03, 2015 at 12:27:34PM +, Peter Maydell wrote: >> Do consumers care if we write out a dump with FP register >> state for a CPU which doesn't implement FP? (For AArch64 >> FP is always present, but for AArch32 it may not be.) > > I

Re: [Qemu-devel] [PATCH v2 6/6] target-arm: dump-guest-memory: add fpregset notes

2015-12-03 Thread Andrew Jones
On Thu, Dec 03, 2015 at 12:27:34PM +, Peter Maydell wrote: > On 25 November 2015 at 00:37, Andrew Jones wrote: > > Also refactors note init code to avoid code duplication. > > Can you squash those parts down into the preceding patch? Sure, but there wasn't any duplication of code in the firs

Re: [Qemu-devel] [PATCH v2 6/6] target-arm: dump-guest-memory: add fpregset notes

2015-12-03 Thread Peter Maydell
On 25 November 2015 at 00:37, Andrew Jones wrote: > Also refactors note init code to avoid code duplication. Can you squash those parts down into the preceding patch? > > Signed-off-by: Andrew Jones > --- > target-arm/arch_dump.c | 161 > ++--- > 1

[Qemu-devel] [PATCH v2 6/6] target-arm: dump-guest-memory: add fpregset notes

2015-11-24 Thread Andrew Jones
Also refactors note init code to avoid code duplication. Signed-off-by: Andrew Jones --- target-arm/arch_dump.c | 161 ++--- 1 file changed, 139 insertions(+), 22 deletions(-) diff --git a/target-arm/arch_dump.c b/target-arm/arch_dump.c index 5debe549