Re: [Qemu-devel] [PATCH v2 56/60] target-i386: Tidy gen_add_A0_im

2013-12-27 Thread Peter Maydell
On 27 December 2013 15:17, Richard Henderson wrote: > On 12/26/2013 02:34 PM, Peter Maydell wrote: >> Looking a bit more closely, is it even possible for code64 to be >> 1 if we're in real or vm86 mode? If not, then the behaviour here >> is unchanged (ie still always zero extends). > > No, real or

Re: [Qemu-devel] [PATCH v2 56/60] target-i386: Tidy gen_add_A0_im

2013-12-27 Thread Richard Henderson
On 12/26/2013 02:34 PM, Peter Maydell wrote: > Looking a bit more closely, is it even possible for code64 to be > 1 if we're in real or vm86 mode? If not, then the behaviour here > is unchanged (ie still always zero extends). No, real or vm86 mode implies 16-bit. r~

Re: [Qemu-devel] [PATCH v2 56/60] target-i386: Tidy gen_add_A0_im

2013-12-26 Thread Peter Maydell
On 26 December 2013 19:10, Richard Henderson wrote: > On 12/26/2013 10:58 AM, Peter Maydell wrote: >>> @@ -6231,7 +6214,7 @@ static target_ulong disas_insn(CPUX86State *env, >>> DisasContext *s, >>> exception */ >>> gen_op_jmp_T0(); >>> /* pop selector */

Re: [Qemu-devel] [PATCH v2 56/60] target-i386: Tidy gen_add_A0_im

2013-12-26 Thread Richard Henderson
On 12/26/2013 10:58 AM, Peter Maydell wrote: > On 29 November 2013 03:00, Richard Henderson wrote: >> Merge gen_op_addl_A0_im and gen_op_addq_A0_im into gen_add_A0_im >> and clean up the ifdef. >> >> Replace the one remaining user of gen_op_addl_A0_im with gen_add_A0_im. >> >> Signed-off-by: Richa

Re: [Qemu-devel] [PATCH v2 56/60] target-i386: Tidy gen_add_A0_im

2013-12-26 Thread Peter Maydell
On 29 November 2013 03:00, Richard Henderson wrote: > Merge gen_op_addl_A0_im and gen_op_addq_A0_im into gen_add_A0_im > and clean up the ifdef. > > Replace the one remaining user of gen_op_addl_A0_im with gen_add_A0_im. > > Signed-off-by: Richard Henderson > --- > target-i386/translate.c | 27 +

[Qemu-devel] [PATCH v2 56/60] target-i386: Tidy gen_add_A0_im

2013-11-28 Thread Richard Henderson
Merge gen_op_addl_A0_im and gen_op_addq_A0_im into gen_add_A0_im and clean up the ifdef. Replace the one remaining user of gen_op_addl_A0_im with gen_add_A0_im. Signed-off-by: Richard Henderson --- target-i386/translate.c | 27 +-- 1 file changed, 5 insertions(+), 22 del