Re: [Qemu-devel] [PATCH v2 51/54] qapi: make s390 commands depend on TARGET_S390X

2017-08-22 Thread Markus Armbruster
David Hildenbrand writes: > On 22.08.2017 16:24, Cornelia Huck wrote: >> On Tue, 22 Aug 2017 15:22:52 +0200 >> Marc-André Lureau wrote: >> >>> Signed-off-by: Marc-André Lureau >>> --- >>> qapi-schema.json| 10 +++--- >>> include/sysemu/arch_init.h | 6

Re: [Qemu-devel] [PATCH v2 51/54] qapi: make s390 commands depend on TARGET_S390X

2017-08-22 Thread Markus Armbruster
David Hildenbrand writes: >> Yes, but Marc-André's patch makes the "not supported yet" information >> available in query-qmp-schema. Carrying such information is pretty much >> the point of schema introspection. >> >> We could add a comment explaining this command isn't target-specific, >> but

Re: [Qemu-devel] [PATCH v2 51/54] qapi: make s390 commands depend on TARGET_S390X

2017-08-22 Thread David Hildenbrand
> Yes, but Marc-André's patch makes the "not supported yet" information > available in query-qmp-schema. Carrying such information is pretty much > the point of schema introspection. > > We could add a comment explaining this command isn't target-specific, > but just happens not to be implemente

Re: [Qemu-devel] [PATCH v2 51/54] qapi: make s390 commands depend on TARGET_S390X

2017-08-22 Thread Marc-André Lureau
Hi - Original Message - > On Tue, 22 Aug 2017 10:41:34 -0400 (EDT) > Marc-André Lureau wrote: > > > Hi > > > > - Original Message - > > > On 22.08.2017 16:24, Cornelia Huck wrote: > > > > On Tue, 22 Aug 2017 15:22:52 +0200 > > > > Marc-André Lureau wrote: > > > > >> @@ -4621,7

Re: [Qemu-devel] [PATCH v2 51/54] qapi: make s390 commands depend on TARGET_S390X

2017-08-22 Thread Cornelia Huck
On Tue, 22 Aug 2017 10:41:34 -0400 (EDT) Marc-André Lureau wrote: > Hi > > - Original Message - > > On 22.08.2017 16:24, Cornelia Huck wrote: > > > On Tue, 22 Aug 2017 15:22:52 +0200 > > > Marc-André Lureau wrote: > > >> @@ -4621,7 +4622,9 @@ > > >> ## > > >> { 'command': 'query-cp

Re: [Qemu-devel] [PATCH v2 51/54] qapi: make s390 commands depend on TARGET_S390X

2017-08-22 Thread Marc-André Lureau
Hi - Original Message - > On 22.08.2017 16:24, Cornelia Huck wrote: > > On Tue, 22 Aug 2017 15:22:52 +0200 > > Marc-André Lureau wrote: > > > >> Signed-off-by: Marc-André Lureau > >> --- > >> qapi-schema.json| 10 +++--- > >> include/sysemu/arch_init.h

Re: [Qemu-devel] [PATCH v2 51/54] qapi: make s390 commands depend on TARGET_S390X

2017-08-22 Thread Cornelia Huck
On Tue, 22 Aug 2017 15:22:52 +0200 Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > qapi-schema.json| 10 +++--- > include/sysemu/arch_init.h | 6 -- > monitor.c | 14 -- > qmp.c

Re: [Qemu-devel] [PATCH v2 51/54] qapi: make s390 commands depend on TARGET_S390X

2017-08-22 Thread David Hildenbrand
On 22.08.2017 16:24, Cornelia Huck wrote: > On Tue, 22 Aug 2017 15:22:52 +0200 > Marc-André Lureau wrote: > >> Signed-off-by: Marc-André Lureau >> --- >> qapi-schema.json| 10 +++--- >> include/sysemu/arch_init.h | 6 -- >> monitor.c

[Qemu-devel] [PATCH v2 51/54] qapi: make s390 commands depend on TARGET_S390X

2017-08-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- qapi-schema.json| 10 +++--- include/sysemu/arch_init.h | 6 -- monitor.c | 14 -- qmp.c | 14 -- stubs/arch-query-cpu-model-b