Re: [Qemu-devel] [PATCH v2 5/5] qmp: Add example usage of strto*l() qemu wrapper

2015-07-19 Thread Carlos L. Torres
On Sun, Jul 19, 2015 at 07:51:00PM +0200, Paolo Bonzini wrote: > > > On 19/07/2015 01:52, Carlos L. Torres wrote: > > +int err; > > > > info->qemu = g_new0(VersionTriple, 1); > > -info->qemu->major = strtol(version, &tmp, 10); > > +err = qemu_strtol(version, &tmp, 10, &(info->q

Re: [Qemu-devel] [PATCH v2 5/5] qmp: Add example usage of strto*l() qemu wrapper

2015-07-19 Thread Paolo Bonzini
On 19/07/2015 01:52, Carlos L. Torres wrote: > +int err; > > info->qemu = g_new0(VersionTriple, 1); > -info->qemu->major = strtol(version, &tmp, 10); > +err = qemu_strtol(version, &tmp, 10, &(info->qemu->major)); There are usually no parentheses around the argument of the & op

[Qemu-devel] [PATCH v2 5/5] qmp: Add example usage of strto*l() qemu wrapper

2015-07-18 Thread Carlos L. Torres
From: "Carlos L. Torres" Signed-off-by: Carlos L. Torres --- qmp.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/qmp.c b/qmp.c index 403805a..837cb3f 100644 --- a/qmp.c +++ b/qmp.c @@ -49,14 +49,27 @@ VersionInfo *qmp_query_version(Error **errp) {