Re: [Qemu-devel] [PATCH v2 40/45] osdep: introduce qemu_mprotect_rwx/none

2017-07-17 Thread Emilio G. Cota
On Mon, Jul 17, 2017 at 18:26:09 -1000, Richard Henderson wrote: > On 07/16/2017 10:04 AM, Emilio G. Cota wrote: > >+static int qemu_mprotect__osdep(void *addr, size_t size, int prot) > >+{ > >+void *start = QEMU_ALIGN_PTR_DOWN(addr, qemu_real_host_page_size); > >+void *end = QEMU_ALIGN_PTR

Re: [Qemu-devel] [PATCH v2 40/45] osdep: introduce qemu_mprotect_rwx/none

2017-07-17 Thread Richard Henderson
On 07/16/2017 10:04 AM, Emilio G. Cota wrote: +static int qemu_mprotect__osdep(void *addr, size_t size, int prot) +{ +void *start = QEMU_ALIGN_PTR_DOWN(addr, qemu_real_host_page_size); +void *end = QEMU_ALIGN_PTR_UP(addr + size, qemu_real_host_page_size); I'm not keen on this. Any good

[Qemu-devel] [PATCH v2 40/45] osdep: introduce qemu_mprotect_rwx/none

2017-07-16 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- include/qemu/osdep.h | 2 ++ util/osdep.c | 40 2 files changed, 42 insertions(+) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 3cb36e6..dcecfbc 100644 --- a/include/qemu/osdep.h +++ b/include/qe