Re: [Qemu-devel] [PATCH v2 4/9] block/commit: utilize job_exit shim

2018-08-27 Thread Max Reitz
On 2018-08-24 00:08, John Snow wrote: > Change the manual deferment to commit_complete into the implicit > callback to job_exit, renaming commit_complete to commit_exit. > > This conversion does change the timing of when job_completed is > called to after the bdrv_replace_node and bdrv_unref calls

[Qemu-devel] [PATCH v2 4/9] block/commit: utilize job_exit shim

2018-08-23 Thread John Snow
Change the manual deferment to commit_complete into the implicit callback to job_exit, renaming commit_complete to commit_exit. This conversion does change the timing of when job_completed is called to after the bdrv_replace_node and bdrv_unref calls, which could have implications for bjob->blk wh