Re: [Qemu-devel] [PATCH v2 4/7] disas: arm: QOMify target specific disas setup

2015-05-24 Thread Peter Crosthwaite
On Mon, May 18, 2015 at 9:31 AM, Peter Maydell wrote: > On 9 May 2015 at 21:11, Peter Crosthwaite wrote: >> Move the target_disas() ARM specifics to the QOM disas_set_info hook >> >> +static int >> +print_insn_thumb1(bfd_vma pc, disassemble_info *info) >> +{ >> + return print_insn_arm(pc | 1, i

Re: [Qemu-devel] [PATCH v2 4/7] disas: arm: QOMify target specific disas setup

2015-05-18 Thread Peter Maydell
On 9 May 2015 at 21:11, Peter Crosthwaite wrote: > Move the target_disas() ARM specifics to the QOM disas_set_info hook > and delete the ARM specific code in disas.c. > > This has the extra advantage of the more fully featured target_disas() > implementation now applying to monitor_disas(). > > Cu

[Qemu-devel] [PATCH v2 4/7] disas: arm: QOMify target specific disas setup

2015-05-09 Thread Peter Crosthwaite
Move the target_disas() ARM specifics to the QOM disas_set_info hook and delete the ARM specific code in disas.c. This has the extra advantage of the more fully featured target_disas() implementation now applying to monitor_disas(). Currently, target_disas() has multi-endian, thumb and AArch64 su