Re: [Qemu-devel] [PATCH v2 4/7] bootindex: delete bootindex when device is removed

2014-08-03 Thread Gonglei (Arei)
Hi, > > > > > > > +del_boot_device_path(dev); > > > > > > You can call this from device_finalize() instead of placing it into each > > > individual device. > > > > > Maybe put this call in device_finalize is not a good idea. > > I have three reasons: > > > > 1. the device's some memory have be

Re: [Qemu-devel] [PATCH v2 4/7] bootindex: delete bootindex when device is removed

2014-08-01 Thread Eduardo Habkost
On Wed, Jul 30, 2014 at 07:29:56AM +, Gonglei (Arei) wrote: > Hi, > > > -Original Message- > > From: Gerd Hoffmann [mailto:kra...@redhat.com] > > Sent: Friday, July 25, 2014 5:52 PM > > > > > +del_boot_device_path(dev); > > > > You can call this from device_finalize() instead of

Re: [Qemu-devel] [PATCH v2 4/7] bootindex: delete bootindex when device is removed

2014-07-30 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, July 25, 2014 5:52 PM > > > +del_boot_device_path(dev); > > You can call this from device_finalize() instead of placing it into each > individual device. > Maybe put this call in device_finaliz

Re: [Qemu-devel] [PATCH v2 4/7] bootindex: delete bootindex when device is removed

2014-07-25 Thread Gonglei (Arei)
Hi, Gerd > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, July 25, 2014 5:52 PM > Subject: Re: [PATCH v2 4/7] bootindex: delete bootindex when device is > removed > > Hi, > > > +del_boot_device_path(dev); > > You can call this from device_finali

Re: [Qemu-devel] [PATCH v2 4/7] bootindex: delete bootindex when device is removed

2014-07-25 Thread Gerd Hoffmann
Hi, > +del_boot_device_path(dev); You can call this from device_finalize() instead of placing it into each individual device. cheers, Gerd

[Qemu-devel] [PATCH v2 4/7] bootindex: delete bootindex when device is removed

2014-07-24 Thread arei.gonglei
From: Gonglei Device should be removed from global boot list when it is hot-unplugged. Signed-off-by: Chenliang Signed-off-by: Gonglei --- hw/block/virtio-blk.c| 1 + hw/i386/kvm/pci-assign.c | 1 + hw/misc/vfio.c | 1 + hw/net/e1000.c | 1 + hw/net/eepro100.c|