Re: [Qemu-devel] [PATCH v2 4/6] msix: Split PBA into it's own MemoryRegion

2012-06-14 Thread Michael S. Tsirkin
On Thu, Jun 14, 2012 at 10:02:58AM -0600, Alex Williamson wrote: > On Thu, 2012-06-14 at 18:45 +0300, Michael S. Tsirkin wrote: > > On Thu, Jun 14, 2012 at 09:09:47AM -0600, Alex Williamson wrote: > > > On Thu, 2012-06-14 at 17:50 +0300, Michael S. Tsirkin wrote: > > > > On Thu, Jun 14, 2012 at 08:

Re: [Qemu-devel] [PATCH v2 4/6] msix: Split PBA into it's own MemoryRegion

2012-06-14 Thread Alex Williamson
On Thu, 2012-06-14 at 18:45 +0300, Michael S. Tsirkin wrote: > On Thu, Jun 14, 2012 at 09:09:47AM -0600, Alex Williamson wrote: > > On Thu, 2012-06-14 at 17:50 +0300, Michael S. Tsirkin wrote: > > > On Thu, Jun 14, 2012 at 08:21:39AM -0600, Alex Williamson wrote: > > > > On Thu, 2012-06-14 at 13:24

Re: [Qemu-devel] [PATCH v2 4/6] msix: Split PBA into it's own MemoryRegion

2012-06-14 Thread Michael S. Tsirkin
On Thu, Jun 14, 2012 at 09:09:47AM -0600, Alex Williamson wrote: > On Thu, 2012-06-14 at 17:50 +0300, Michael S. Tsirkin wrote: > > On Thu, Jun 14, 2012 at 08:21:39AM -0600, Alex Williamson wrote: > > > On Thu, 2012-06-14 at 13:24 +0300, Michael S. Tsirkin wrote: > > > > On Wed, Jun 13, 2012 at 10:

Re: [Qemu-devel] [PATCH v2 4/6] msix: Split PBA into it's own MemoryRegion

2012-06-14 Thread Alex Williamson
On Thu, 2012-06-14 at 17:50 +0300, Michael S. Tsirkin wrote: > On Thu, Jun 14, 2012 at 08:21:39AM -0600, Alex Williamson wrote: > > On Thu, 2012-06-14 at 13:24 +0300, Michael S. Tsirkin wrote: > > > On Wed, Jun 13, 2012 at 10:51:47PM -0600, Alex Williamson wrote: > > > > These don't have to be cont

Re: [Qemu-devel] [PATCH v2 4/6] msix: Split PBA into it's own MemoryRegion

2012-06-14 Thread Michael S. Tsirkin
On Thu, Jun 14, 2012 at 08:21:39AM -0600, Alex Williamson wrote: > On Thu, 2012-06-14 at 13:24 +0300, Michael S. Tsirkin wrote: > > On Wed, Jun 13, 2012 at 10:51:47PM -0600, Alex Williamson wrote: > > > These don't have to be contiguous. Size them to only what > > > they need and use separate Memo

Re: [Qemu-devel] [PATCH v2 4/6] msix: Split PBA into it's own MemoryRegion

2012-06-14 Thread Alex Williamson
On Thu, 2012-06-14 at 08:13 +0200, Jan Kiszka wrote: > On 2012-06-14 06:51, Alex Williamson wrote: > > > > -memory_region_init_io(&dev->msix_mmio, &msix_mmio_ops, dev, > > - "msix", MSIX_PAGE_SIZE); > > +memory_region_init_io(&dev->msix_table_mmio, &msix_table_mmi

Re: [Qemu-devel] [PATCH v2 4/6] msix: Split PBA into it's own MemoryRegion

2012-06-14 Thread Alex Williamson
On Thu, 2012-06-14 at 13:24 +0300, Michael S. Tsirkin wrote: > On Wed, Jun 13, 2012 at 10:51:47PM -0600, Alex Williamson wrote: > > These don't have to be contiguous. Size them to only what > > they need and use separate MemoryRegions for the vector > > table and PBA. > > > > Signed-off-by: Alex

Re: [Qemu-devel] [PATCH v2 4/6] msix: Split PBA into it's own MemoryRegion

2012-06-14 Thread Michael S. Tsirkin
On Wed, Jun 13, 2012 at 10:51:47PM -0600, Alex Williamson wrote: > These don't have to be contiguous. Size them to only what > they need and use separate MemoryRegions for the vector > table and PBA. > > Signed-off-by: Alex Williamson Why is this still using NATIVE? > --- > > hw/msix.c | 11

Re: [Qemu-devel] [PATCH v2 4/6] msix: Split PBA into it's own MemoryRegion

2012-06-13 Thread Jan Kiszka
On 2012-06-14 06:51, Alex Williamson wrote: > These don't have to be contiguous. Size them to only what > they need and use separate MemoryRegions for the vector > table and PBA. > > Signed-off-by: Alex Williamson > --- > > hw/msix.c | 116 > ++

[Qemu-devel] [PATCH v2 4/6] msix: Split PBA into it's own MemoryRegion

2012-06-13 Thread Alex Williamson
These don't have to be contiguous. Size them to only what they need and use separate MemoryRegions for the vector table and PBA. Signed-off-by: Alex Williamson --- hw/msix.c | 116 ++--- hw/pci.h | 15 ++-- 2 files changed, 83 ins