Re: [Qemu-devel] [PATCH v2 4/4] linux-user: pass strace argument in execve

2016-06-20 Thread Joel Holdsworth
On 15/06/16 21:37, Laurent Vivier wrote: This is not needed: if you use QEMU_STRACE environment variable, it is propagated to the child processes (this is also true for "-L" and QEMU_LD_PREFIX). I would say that breaks the rule of least surprise for the user. If we're going to invoke a child ins

Re: [Qemu-devel] [PATCH v2 4/4] linux-user: pass strace argument in execve

2016-06-15 Thread Laurent Vivier
This is not needed: if you use QEMU_STRACE environment variable, it is propagated to the child processes (this is also true for "-L" and QEMU_LD_PREFIX). In fact, your patch 2 breaks this... Did you try to use a statically linked qemu? IMHO, the best way to avoid environment problem is to have a

[Qemu-devel] [PATCH v2 4/4] linux-user: pass strace argument in execve

2016-06-14 Thread Joel Holdsworth
--- linux-user/syscall.c | 5 + 1 file changed, 5 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 1513f0f..00ee7a6 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -6778,6 +6778,8 @@ static abi_long qemu_execve(char *filename, char *argv[], qem