Re: [Qemu-devel] [PATCH v2 4/4] hw/acpi: Extract build_mcfg to pci.c

2019-04-16 Thread Wei Yang
On Mon, Apr 15, 2019 at 03:01:28PM +0200, Philippe Mathieu-Daud?? wrote: >Hi Wei, > >On 4/15/19 9:03 AM, Wei Yang wrote: >> Now we have two identical build_mcfg function. >> >> Extract them to pci.c. >> >> Signed-off-by: Wei Yang >> >> --- >> v2: >> * put it to dedicated file pci.c >> --- >>

Re: [Qemu-devel] [PATCH v2 4/4] hw/acpi: Extract build_mcfg to pci.c

2019-04-15 Thread Igor Mammedov
On Mon, 15 Apr 2019 15:03:07 +0800 Wei Yang wrote: > Now we have two identical build_mcfg function. s/function./functions,/ > > Extract them to pci.c. s|.*|consolidate them in acpi/pci.c| > > Signed-off-by: Wei Yang with above and Philippe's comment addressed Reviewed-by: Igor Mammedov

Re: [Qemu-devel] [PATCH v2 4/4] hw/acpi: Extract build_mcfg to pci.c

2019-04-15 Thread Philippe Mathieu-Daudé
Hi Wei, On 4/15/19 9:03 AM, Wei Yang wrote: > Now we have two identical build_mcfg function. > > Extract them to pci.c. > > Signed-off-by: Wei Yang > > --- > v2: > * put it to dedicated file pci.c > --- > default-configs/arm-softmmu.mak | 1 + > default-configs/i386-softmmu.mak | 1 + >

[Qemu-devel] [PATCH v2 4/4] hw/acpi: Extract build_mcfg to pci.c

2019-04-15 Thread Wei Yang
Now we have two identical build_mcfg function. Extract them to pci.c. Signed-off-by: Wei Yang --- v2: * put it to dedicated file pci.c --- default-configs/arm-softmmu.mak | 1 + default-configs/i386-softmmu.mak | 1 + hw/acpi/Kconfig | 4 +++ hw/acpi/Makefile.objs