Re: [Qemu-devel] [PATCH v2 33/45] ivshmem-server: fix hugetlbfs support

2015-07-28 Thread Andrew Jones
On Tue, Jul 28, 2015 at 08:02:54PM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Jul 28, 2015 at 9:33 AM, Andrew Jones wrote: > > On Tue, Jul 28, 2015 at 02:32:45AM +0200, Marc-André Lureau wrote: > >> + > >> +return fs.f_bsize; > >> +} > >> + > >> + > >> + > > few extra lines here > > cu

Re: [Qemu-devel] [PATCH v2 33/45] ivshmem-server: fix hugetlbfs support

2015-07-28 Thread Marc-André Lureau
Hi On Tue, Jul 28, 2015 at 9:33 AM, Andrew Jones wrote: > On Tue, Jul 28, 2015 at 02:32:45AM +0200, Marc-André Lureau wrote: >> + >> +return fs.f_bsize; >> +} >> + >> + >> + > few extra lines here cut, thanks >> /* open shm, create and bind to the unix socket */ >> int >> ivshmem_server_

Re: [Qemu-devel] [PATCH v2 33/45] ivshmem-server: fix hugetlbfs support

2015-07-28 Thread Andrew Jones
On Tue, Jul 28, 2015 at 02:32:45AM +0200, Marc-André Lureau wrote: > From: Marc-André Lureau > > As pointed out on the ML by Andrew Jones, glibc no longer permits > creating POSIX shm on hugetlbfs directly. When given a hugetlbfs path, > create a shareable file there. > > Signed-off-by: Marc-And

[Qemu-devel] [PATCH v2 33/45] ivshmem-server: fix hugetlbfs support

2015-07-27 Thread Marc-André Lureau
From: Marc-André Lureau As pointed out on the ML by Andrew Jones, glibc no longer permits creating POSIX shm on hugetlbfs directly. When given a hugetlbfs path, create a shareable file there. Signed-off-by: Marc-André Lureau --- contrib/ivshmem-server/ivshmem-server.c | 47