Re: [Qemu-devel] [PATCH v2 3/6] pvrdma: check number of pages when creating rings

2018-12-17 Thread Yuval Shaia
On Tue, Dec 18, 2018 at 12:17:59AM +0530, P J P wrote: > Hello Yuval, > > +-- On Sun, 16 Dec 2018, Yuval Shaia wrote --+ > | With this patch the last step fails, the guest OS hangs, trying to probably > | unload pvrdma driver and finally gave up after 3 minutes. > > Strange... > > | Anyways

Re: [Qemu-devel] [PATCH v2 3/6] pvrdma: check number of pages when creating rings

2018-12-17 Thread P J P
Hello Yuval, +-- On Sun, 16 Dec 2018, Yuval Shaia wrote --+ | With this patch the last step fails, the guest OS hangs, trying to probably | unload pvrdma driver and finally gave up after 3 minutes. Strange... | Anyways with debug turned on i have noticed that there is one case that | device

Re: [Qemu-devel] [PATCH v2 3/6] pvrdma: check number of pages when creating rings

2018-12-16 Thread Yuval Shaia
Hi Prasad, Turned out that this patch cause a regression. My test plan includes the following steps: - Start two VMs. - Run RC and UD traffic between the two. - Run sanity local test on both which includes: - RC traffic on 3 gids with various message size. - UD traffic. - R

[Qemu-devel] [PATCH v2 3/6] pvrdma: check number of pages when creating rings

2018-12-12 Thread P J P
From: Prasad J Pandit When creating CQ/QP rings, an object can have up to PVRDMA_MAX_FAST_REG_PAGES=128 pages. Check 'npages' parameter to avoid excessive memory allocation or a null dereference. Reported-by: Li Qiang Signed-off-by: Prasad J Pandit --- hw/rdma/vmw/pvrdma_cmd.c | 11 ++