On 06/15/2017 02:19 PM, Aurelien Jarno wrote:
While the above looks correct, it's not complete. It only fixes the
microMIPS EI instruction. The MIPS one also has to be fixed.
For what I understood, anything that can change the result of
cpu_mips_hw_interrupts_enabled has to stop the translation.
On 2017-06-14 12:48, Richard Henderson wrote:
> From: Paolo Bonzini
>
> Exit to cpu loop so we reevaluate cpu_mips_hw_interrupts.
>
> Cc: Aurelien Jarno
> Cc: Yongbok Kim
> Signed-off-by: Richard Henderson
> ---
> target/mips/translate.c | 6 --
> 1 file changed, 4 insertions(+), 2 delet
On 15/06/2017 10:57, Alex Bennée wrote:
>> +/* BS_STOP isn't good enough here;
>> + reevaluate cpu_mips_hw_interrupts_enabled. */
> nit: technically we want to ensure mips_cpu_exec_interrupt is run (which
> calls cpu_mips_hw_interrupts_enabled)
Right, that's why
Richard Henderson writes:
> From: Paolo Bonzini
>
> Exit to cpu loop so we reevaluate cpu_mips_hw_interrupts.
>
> Cc: Aurelien Jarno
> Cc: Yongbok Kim
> Signed-off-by: Richard Henderson
> ---
> target/mips/translate.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --
From: Paolo Bonzini
Exit to cpu loop so we reevaluate cpu_mips_hw_interrupts.
Cc: Aurelien Jarno
Cc: Yongbok Kim
Signed-off-by: Richard Henderson
---
target/mips/translate.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/target/mips/translate.c b/target/mips/transl