Re: [Qemu-devel] [PATCH v2 3/5] block/rbd: parse all options via bdrv_parse_filename

2017-02-27 Thread Eric Blake
On 02/27/2017 04:56 PM, Jeff Cody wrote: >>> static BlockDriver bdrv_rbd = { > >>> -.instance_size = sizeof(BDRVRBDState), >>> -.bdrv_needs_filename = true, >>> -.bdrv_file_open = qemu_rbd_open, >>> -.bdrv_close = qemu_rbd_close, >>> -.bdrv_create= qe

Re: [Qemu-devel] [PATCH v2 3/5] block/rbd: parse all options via bdrv_parse_filename

2017-02-27 Thread Jeff Cody
On Mon, Feb 27, 2017 at 04:35:58PM -0600, Eric Blake wrote: > On 02/27/2017 12:58 PM, Jeff Cody wrote: > > Get rid of qemu_rbd_parsename in favor of bdrv_parse_filename. > > This simplifies a lot of the parsing as well, as we can treat everything > > a bit simpler since nonexistent options are simp

Re: [Qemu-devel] [PATCH v2 3/5] block/rbd: parse all options via bdrv_parse_filename

2017-02-27 Thread Eric Blake
On 02/27/2017 12:58 PM, Jeff Cody wrote: > Get rid of qemu_rbd_parsename in favor of bdrv_parse_filename. > This simplifies a lot of the parsing as well, as we can treat everything > a bit simpler since nonexistent options are simply NULL pointers instead > of empy strings. s/empy/empty/ > > An

[Qemu-devel] [PATCH v2 3/5] block/rbd: parse all options via bdrv_parse_filename

2017-02-27 Thread Jeff Cody
Get rid of qemu_rbd_parsename in favor of bdrv_parse_filename. This simplifies a lot of the parsing as well, as we can treat everything a bit simpler since nonexistent options are simply NULL pointers instead of empy strings. An important item to note: Ceph has many extra option values that can b