Re: [Qemu-devel] [PATCH v2 3/4] qapi: return a 'missing parameter' error

2016-09-22 Thread Marc-André Lureau
Hi - Original Message - > Marc-André Lureau writes: > > > The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing > > parameters, but the qapi qmp_dispatch() code uses > > QERR_INVALID_PARAMETER_TYPE. > > > > Improve qapi code to return QERR_INVALID_PARAMETER_TYPE where > >

Re: [Qemu-devel] [PATCH v2 3/4] qapi: return a 'missing parameter' error

2016-09-22 Thread Markus Armbruster
Marc-André Lureau writes: > The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing > parameters, but the qapi qmp_dispatch() code uses > QERR_INVALID_PARAMETER_TYPE. > > Improve qapi code to return QERR_INVALID_PARAMETER_TYPE where > appropriate. > > Signed-off-by: Marc-André Lurea

Re: [Qemu-devel] [PATCH v2 3/4] qapi: return a 'missing parameter' error

2016-09-22 Thread Daniel P. Berrange
On Thu, Sep 22, 2016 at 12:10:17AM +0400, Marc-André Lureau wrote: > The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing > parameters, but the qapi qmp_dispatch() code uses > QERR_INVALID_PARAMETER_TYPE. > > Improve qapi code to return QERR_INVALID_PARAMETER_TYPE where > appropri

Re: [Qemu-devel] [PATCH v2 3/4] qapi: return a 'missing parameter' error

2016-09-21 Thread Eric Blake
On 09/21/2016 03:10 PM, Marc-André Lureau wrote: > The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing > parameters, but the qapi qmp_dispatch() code uses > QERR_INVALID_PARAMETER_TYPE. > > Improve qapi code to return QERR_INVALID_PARAMETER_TYPE where > appropriate. > > Signed-o

[Qemu-devel] [PATCH v2 3/4] qapi: return a 'missing parameter' error

2016-09-21 Thread Marc-André Lureau
The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing parameters, but the qapi qmp_dispatch() code uses QERR_INVALID_PARAMETER_TYPE. Improve qapi code to return QERR_INVALID_PARAMETER_TYPE where appropriate. Signed-off-by: Marc-André Lureau Reviewed-by: Alberto Garcia --- qapi/