Re: [Qemu-devel] [PATCH v2 3/4] chardev: use per-dev context for io_add_watch_poll

2017-09-22 Thread Peter Xu
On Thu, Sep 21, 2017 at 04:11:33PM +0200, Paolo Bonzini wrote: > On 21/09/2017 08:35, Peter Xu wrote: > > It was only passed in by chr_update_read_handlers(). However when > > reconnect, we'll lose that context information. So if a chardev was > > running on another context (rather than the defau

Re: [Qemu-devel] [PATCH v2 3/4] chardev: use per-dev context for io_add_watch_poll

2017-09-21 Thread Paolo Bonzini
On 21/09/2017 08:35, Peter Xu wrote: > It was only passed in by chr_update_read_handlers(). However when > reconnect, we'll lose that context information. So if a chardev was > running on another context (rather than the default context, the NULL > pointer), it'll switch back to the default conte

[Qemu-devel] [PATCH v2 3/4] chardev: use per-dev context for io_add_watch_poll

2017-09-20 Thread Peter Xu
It was only passed in by chr_update_read_handlers(). However when reconnect, we'll lose that context information. So if a chardev was running on another context (rather than the default context, the NULL pointer), it'll switch back to the default context if reconnection happens. But, it should r