Re: [Qemu-devel] [PATCH v2 3/3] target-i386: add AES-NI instructions

2013-03-29 Thread Aurelien Jarno
On Fri, Mar 29, 2013 at 12:46:49AM +0100, Edgar E. Iglesias wrote: > On Fri, Mar 29, 2013 at 12:36:29AM +0100, Aurelien Jarno wrote: > > Signed-off-by: Aurelien Jarno > > Hi Aurelien, > > Nice patches! > > A question - The sbox tables are already available but in > a different format in util/ae

Re: [Qemu-devel] [PATCH v2 3/3] target-i386: add AES-NI instructions

2013-03-28 Thread Edgar E. Iglesias
On Fri, Mar 29, 2013 at 12:36:29AM +0100, Aurelien Jarno wrote: > Signed-off-by: Aurelien Jarno Hi Aurelien, Nice patches! A question - The sbox tables are already available but in a different format in util/aes.c. Would it make sense to reuse (see Te4 and Td4) ? Cheers, Edgar > --- > targe

[Qemu-devel] [PATCH v2 3/3] target-i386: add AES-NI instructions

2013-03-28 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- target-i386/cpu.c|6 +- target-i386/ops_sse.h| 188 ++ target-i386/ops_sse_header.h |6 ++ target-i386/translate.c |7 ++ 4 files changed, 204 insertions(+), 3 deletions(-) diff --git