Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

2012-06-06 Thread Anthony Liguori
On 06/07/2012 01:26 PM, Paolo Bonzini wrote: Il 07/06/2012 05:16, Anthony Liguori ha scritto: On 06/06/2012 07:54 PM, Paolo Bonzini wrote: From e0e6e5b689cbcb782bca8f158fad89b3389e9e11 Mon Sep 17 00:00:00 2001 From: Anthony Liguori Date: Wed, 6 Jun 2012 16:57:00 +0800 Subject: [PATCH] config

Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

2012-06-06 Thread Paolo Bonzini
Il 07/06/2012 05:16, Anthony Liguori ha scritto: > On 06/06/2012 07:54 PM, Paolo Bonzini wrote: >>> From e0e6e5b689cbcb782bca8f158fad89b3389e9e11 Mon Sep 17 00:00:00 2001 >>> From: Anthony Liguori >>> Date: Wed, 6 Jun 2012 16:57:00 +0800 >>> Subject: [PATCH] configure: ensure directory exists when

Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

2012-06-06 Thread Eric Blake
On 06/06/2012 09:15 PM, Anthony Liguori wrote: > On 06/06/2012 08:16 PM, Paolo Bonzini wrote: >> Il 06/06/2012 14:03, Peter Maydell ha scritto: >>> Can we use >>> mkdir -p "$(dirname "$2")" >>> >>> or are we still trying to be compatible with some non-POSIX >>> shell from the dawn of time? >> >>

Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

2012-06-06 Thread Anthony Liguori
On 06/06/2012 07:54 PM, Paolo Bonzini wrote: From e0e6e5b689cbcb782bca8f158fad89b3389e9e11 Mon Sep 17 00:00:00 2001 From: Anthony Liguori Date: Wed, 6 Jun 2012 16:57:00 +0800 Subject: [PATCH] configure: ensure directory exists when creating symlink Signed-off-by: Anthony Liguori --- configure

Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

2012-06-06 Thread Anthony Liguori
On 06/06/2012 08:16 PM, Paolo Bonzini wrote: Il 06/06/2012 14:03, Peter Maydell ha scritto: Can we use mkdir -p "$(dirname "$2")" or are we still trying to be compatible with some non-POSIX shell from the dawn of time? Looks like we can, there are other occurrences of $() in configure. I

Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

2012-06-06 Thread Paolo Bonzini
Il 06/06/2012 14:03, Peter Maydell ha scritto: > Can we use > mkdir -p "$(dirname "$2")" > > or are we still trying to be compatible with some non-POSIX > shell from the dawn of time? Looks like we can, there are other occurrences of $() in configure. Paolo

Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

2012-06-06 Thread Peter Maydell
On 6 June 2012 12:54, Paolo Bonzini wrote: >> From: Anthony Liguori >> +  mkdir -p `dirname $2` > > Please leave the argument quoted, like > >  dir=`dirname "$2` (missing ", obviously) >  mkdir -p "$dir" Can we use mkdir -p "$(dirname "$2")" or are we still trying to be compatible with some

Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

2012-06-06 Thread Paolo Bonzini
> From e0e6e5b689cbcb782bca8f158fad89b3389e9e11 Mon Sep 17 00:00:00 2001 > From: Anthony Liguori > Date: Wed, 6 Jun 2012 16:57:00 +0800 > Subject: [PATCH] configure: ensure directory exists when creating symlink > > Signed-off-by: Anthony Liguori > --- > configure |3 +-- > 1 files changed,

Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

2012-06-06 Thread Anthony Liguori
This results in failures to create symlinks in a new build directory. The following patch seems to resolve it though. Regards, Anthony Liguori On 06/06/2012 02:36 PM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- configure | 35 ++- rules.mak |

[Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

2012-06-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 35 ++- rules.mak |1 + 2 files changed, 3 insertions(+), 33 deletions(-) diff --git a/configure b/configure index 301b574..07e3ff1 100755 --- a/configure +++ b/configure @@ -3672,26 +3672,6 @@ if [ "$TARGET_BASE_