Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-13 Thread Michael S. Tsirkin
On Fri, Oct 12, 2012 at 11:27:21AM -0400, Jason Baron wrote: > On Thu, Oct 11, 2012 at 10:40:04PM +0200, Michael S. Tsirkin wrote: > > > Windows and Linux guests seem fine with either layout. Slots 1-2 are > > > specific to my setup. So this is a pretty minimal set. > > > > I guess we can remove t

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-12 Thread Jason Baron
On Fri, Oct 12, 2012 at 12:06:44PM +0200, Gerd Hoffmann wrote: > Hi, > > >>> I just tried out getting rid of the bridges by default. > >> > >> That clearly raises the question which devices should be created > >> automatically by -M q35. I think the devices which are part of the ich9 > >> chips

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-12 Thread Jason Baron
On Thu, Oct 11, 2012 at 10:40:04PM +0200, Michael S. Tsirkin wrote: > > Windows and Linux guests seem fine with either layout. Slots 1-2 are > > specific to my setup. So this is a pretty minimal set. > > I guess we can remove the PCI bridge too? > maybe. Perhaps, we can have a very basic set of

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-12 Thread Michael S. Tsirkin
On Fri, Oct 12, 2012 at 12:06:44PM +0200, Gerd Hoffmann wrote: > Hi, > > >>> I just tried out getting rid of the bridges by default. > >> > >> That clearly raises the question which devices should be created > >> automatically by -M q35. I think the devices which are part of the ich9 > >> chips

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-12 Thread Gerd Hoffmann
Hi, >>> I just tried out getting rid of the bridges by default. >> >> That clearly raises the question which devices should be created >> automatically by -M q35. I think the devices which are part of the ich9 >> chipset should be there by default. /me looks at my laptop which >> happens to ha

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-12 Thread Michael S. Tsirkin
On Fri, Oct 12, 2012 at 09:27:02AM +0200, Gerd Hoffmann wrote: > Hi, > > >> Yes. Reason I ask is because q35 is adding bridges by default now. > >> Would it be possible to only add them if requested on command line by user > >> instead? I realize some guests expect devices at specific slots > >>

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-12 Thread Gerd Hoffmann
Hi, >> Yes. Reason I ask is because q35 is adding bridges by default now. >> Would it be possible to only add them if requested on command line by user >> instead? I realize some guests expect devices at specific slots >> but this does not apply to bridges I think? > > I just tried out getting

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-11 Thread Michael S. Tsirkin
On Thu, Oct 11, 2012 at 11:34:08AM -0400, Jason Baron wrote: > On Thu, Oct 11, 2012 at 04:46:56PM +0200, Michael S. Tsirkin wrote: > > On Thu, Oct 11, 2012 at 10:21:22AM -0400, Jason Baron wrote: > > > On Thu, Oct 11, 2012 at 12:57:06PM +0200, Michael S. Tsirkin wrote: > > > > On Mon, Oct 08, 2012

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-11 Thread Jason Baron
On Thu, Oct 11, 2012 at 04:54:53PM +0200, Paolo Bonzini wrote: > Il 11/10/2012 16:46, Michael S. Tsirkin ha scritto: > > Yes. Reason I ask is because q35 is adding bridges by default now. > > Would it be possible to only add them if requested on command line by user > > instead? > > Can you just u

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-11 Thread Jason Baron
On Thu, Oct 11, 2012 at 04:46:56PM +0200, Michael S. Tsirkin wrote: > On Thu, Oct 11, 2012 at 10:21:22AM -0400, Jason Baron wrote: > > On Thu, Oct 11, 2012 at 12:57:06PM +0200, Michael S. Tsirkin wrote: > > > On Mon, Oct 08, 2012 at 11:30:39PM -0400, Jason Baron wrote: > > > > From: Jason Baron >

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-11 Thread Paolo Bonzini
Il 11/10/2012 16:46, Michael S. Tsirkin ha scritto: > Yes. Reason I ask is because q35 is adding bridges by default now. > Would it be possible to only add them if requested on command line by user > instead? Can you just use shpc or pcie hotplug on those bridges? > I realize some guests expect d

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-11 Thread Michael S. Tsirkin
On Thu, Oct 11, 2012 at 10:21:22AM -0400, Jason Baron wrote: > On Thu, Oct 11, 2012 at 12:57:06PM +0200, Michael S. Tsirkin wrote: > > On Mon, Oct 08, 2012 at 11:30:39PM -0400, Jason Baron wrote: > > > From: Jason Baron > > > > > > Add piix style acpi hotplug to q35. > > > > > > Signed-off-by: J

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-11 Thread Jason Baron
On Thu, Oct 11, 2012 at 12:57:06PM +0200, Michael S. Tsirkin wrote: > On Mon, Oct 08, 2012 at 11:30:39PM -0400, Jason Baron wrote: > > From: Jason Baron > > > > Add piix style acpi hotplug to q35. > > > > Signed-off-by: Jason Baron > > Something I don't understand here: this only handles hotpl

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-11 Thread Michael S. Tsirkin
On Mon, Oct 08, 2012 at 11:30:39PM -0400, Jason Baron wrote: > From: Jason Baron > > Add piix style acpi hotplug to q35. > > Signed-off-by: Jason Baron Something I don't understand here: this only handles hotplug of devices behind the root, no? Don't we need support for hotplug/hot remove of d

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-09 Thread Paolo Bonzini
Il 09/10/2012 05:30, Jason Baron ha scritto: > From: Jason Baron > > Add piix style acpi hotplug to q35. > > Signed-off-by: Jason Baron Not a thorough review, but it looks good. Paolo > --- > hw/acpi_ich9.c | 172 > +++- > hw/acpi_ich9.h

[Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-08 Thread Jason Baron
From: Jason Baron Add piix style acpi hotplug to q35. Signed-off-by: Jason Baron --- hw/acpi_ich9.c | 172 +++- hw/acpi_ich9.h | 10 +++ 2 files changed, 181 insertions(+), 1 deletions(-) diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c index