Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression

2014-07-03 Thread Markus Armbruster
Paolo Bonzini writes: > Il 03/07/2014 09:19, Markus Armbruster ha scritto: >>> > I think there is a page with unfinished transition. Can you add this one? >> Do you mean the transition to qdev? >> >> If yes, isn't that covered by "Making all devices QOM objects"? >> Sometimes we create new trans

Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression

2014-07-03 Thread Paolo Bonzini
Il 03/07/2014 09:19, Markus Armbruster ha scritto: > I think there is a page with unfinished transition. Can you add this one? Do you mean the transition to qdev? If yes, isn't that covered by "Making all devices QOM objects"? Sometimes we create new transitions faster than we finish them...

Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression

2014-07-03 Thread Markus Armbruster
Paolo Bonzini writes: > Il 02/07/2014 16:58, Markus Armbruster ha scritto: >> Paolo Bonzini writes: >> >>> Il 02/07/2014 08:55, Markus Armbruster ha scritto: >> I think this fixes itself automatically if you use >> rerror=stop/werror=stop on block jobs. At least that was part of the >>>

Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression

2014-07-02 Thread Eric Blake
On 07/02/2014 09:03 AM, Paolo Bonzini wrote: What if an underlying device doesn't support [rw]error=stop? Not all do... >>> >>> Then the "fix" is to add support to the underlying device. IDE, SCSI >>> and virtio-blk (plus virtio-scsi via SCSI of course) are covered; >> >> Where "covere

Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 16:58, Markus Armbruster ha scritto: Paolo Bonzini writes: Il 02/07/2014 08:55, Markus Armbruster ha scritto: I think this fixes itself automatically if you use rerror=stop/werror=stop on block jobs. At least that was part of the design, whether the implementation gets it right

Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression

2014-07-02 Thread Markus Armbruster
Paolo Bonzini writes: > Il 02/07/2014 08:55, Markus Armbruster ha scritto: >>> > I think this fixes itself automatically if you use >>> > rerror=stop/werror=stop on block jobs. At least that was part of the >>> > design, whether the implementation gets it right I cannot say without >>> > looking

Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 10:44, Kevin Wolf ha scritto: > Then the "fix" is to add support to the underlying device. IDE, > SCSI and virtio-blk (plus virtio-scsi via SCSI of course) are > covered; the main one that's left out is SD. Isn't block job rerror/werror completely independent from the guest device

Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression

2014-07-02 Thread Kevin Wolf
Am 02.07.2014 um 10:23 hat Paolo Bonzini geschrieben: > Il 02/07/2014 08:55, Markus Armbruster ha scritto: > >>> I think this fixes itself automatically if you use > >>> rerror=stop/werror=stop on block jobs. At least that was part of the > >>> design, whether the implementation gets it right I ca

Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 08:55, Markus Armbruster ha scritto: > I think this fixes itself automatically if you use > rerror=stop/werror=stop on block jobs. At least that was part of the > design, whether the implementation gets it right I cannot say without > looking at the code more carefully. What if an

Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression

2014-07-01 Thread Markus Armbruster
Paolo Bonzini writes: > Il 01/07/2014 19:08, Eric Blake ha scritto: >> On 06/27/2014 11:24 AM, Markus Armbruster wrote: >>> Commit bcada37 dropped the (up to now undocumented) members type, len, >>> offset, speed, breaking tests/qemu-iotests/040 and 041. >>> >>> Restore and document them. This f

Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression

2014-07-01 Thread Paolo Bonzini
Il 01/07/2014 19:08, Eric Blake ha scritto: On 06/27/2014 11:24 AM, Markus Armbruster wrote: Commit bcada37 dropped the (up to now undocumented) members type, len, offset, speed, breaking tests/qemu-iotests/040 and 041. Restore and document them. This fixes 040, and partially fixes 041. Signe

Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression

2014-07-01 Thread Eric Blake
On 06/27/2014 11:24 AM, Markus Armbruster wrote: > Commit bcada37 dropped the (up to now undocumented) members type, len, > offset, speed, breaking tests/qemu-iotests/040 and 041. > > Restore and document them. This fixes 040, and partially fixes 041. > > Signed-off-by: Markus Armbruster > Test

[Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression

2014-06-27 Thread Markus Armbruster
Commit bcada37 dropped the (up to now undocumented) members type, len, offset, speed, breaking tests/qemu-iotests/040 and 041. Restore and document them. This fixes 040, and partially fixes 041. Signed-off-by: Markus Armbruster Tested-By: Benoit Canet --- blockjob.c | 6 +- qap