Re: [Qemu-devel] [PATCH v2 2/8] target-i386: x87 exception pointers using TCG.

2014-08-30 Thread Jaume Martí
Hello, I thought that it was more readable with 2 boolean arguments, but I will encode them into a single argument. Also, on fxsave and fxrstor helpers I will encode the data32 and data64 parmeters into a single one. Best regards, Jaume On Sat, Aug 30, 2014 at 12:57 AM, Richard Henderson wrote:

Re: [Qemu-devel] [PATCH v2 2/8] target-i386: x87 exception pointers using TCG.

2014-08-29 Thread Richard Henderson
On 08/28/2014 01:44 PM, Jaume Marti Farriol wrote: > -void helper_fstenv(CPUX86State *env, target_ulong ptr, int data32) > +void helper_fstenv(CPUX86State *env, target_ulong ptr, int data32, > + int protected_mode) You ought not need two arguments here. All of the formats are mu

[Qemu-devel] [PATCH v2 2/8] target-i386: x87 exception pointers using TCG.

2014-08-28 Thread Jaume Marti Farriol
Hello, This patch modifies the helpers for the fpu instructions involved in saving to memory and restoring the x87 exception pointers. Best regards, Jaume fpu_helper.c | 218 --- 1 file changed, 166 insertions(+), 52 deletions(-) signed