Re: [Qemu-devel] [PATCH v2 2/8] target/s390x: Implement CONVERT UNICODE insns

2017-07-03 Thread Richard Henderson
On 07/02/2017 06:18 AM, Aurelien Jarno wrote: +if (!s390_has_feat(s->insn->fac == S390_FEAT_EXTENDED_TRANSLATION_3 + ? S390_FEAT_ETF3_ENH : S390_FEAT_ETF2_ENH)) { +m3 = 0; +} This doesn't look correct to me. The well-formedness checking is part of ETF3_ENH

Re: [Qemu-devel] [PATCH v2 2/8] target/s390x: Implement CONVERT UNICODE insns

2017-07-02 Thread Aurelien Jarno
On 2017-07-01 13:25, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/helper.h | 6 + > target/s390x/mem_helper.c | 310 > + > target/s390x/translate.c | 44 +++ > target/s390x/insn-data.def | 13 ++ > 4

[Qemu-devel] [PATCH v2 2/8] target/s390x: Implement CONVERT UNICODE insns

2017-07-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/s390x/helper.h | 6 + target/s390x/mem_helper.c | 310 + target/s390x/translate.c | 44 +++ target/s390x/insn-data.def | 13 ++ 4 files changed, 373 insertions(+) diff --git a/target/s390x/hel