Re: [Qemu-devel] [PATCH v2 2/7] s390x/pci: rework PCI STORE

2017-11-22 Thread Pierre Morel
On 22/11/2017 14:25, Cornelia Huck wrote: On Tue, 21 Nov 2017 19:03:17 +0100 Pierre Morel wrote: On 21/11/2017 15:25, Cornelia Huck wrote: On Tue, 21 Nov 2017 11:38:45 +0100 Cornelia Huck wrote: On Thu, 16 Nov 2017 18:51:50 +0100 Pierre Morel wrote: @@ -493,9 +494,13 @@ int pcistg

Re: [Qemu-devel] [PATCH v2 2/7] s390x/pci: rework PCI STORE

2017-11-22 Thread Cornelia Huck
On Tue, 21 Nov 2017 19:03:17 +0100 Pierre Morel wrote: > On 21/11/2017 15:25, Cornelia Huck wrote: > > On Tue, 21 Nov 2017 11:38:45 +0100 > > Cornelia Huck wrote: > > > >> On Thu, 16 Nov 2017 18:51:50 +0100 > >> Pierre Morel wrote: > > > >>> @@ -493,9 +494,13 @@ int pcistg_service_call(

Re: [Qemu-devel] [PATCH v2 2/7] s390x/pci: rework PCI STORE

2017-11-21 Thread Pierre Morel
On 21/11/2017 15:25, Cornelia Huck wrote: On Tue, 21 Nov 2017 11:38:45 +0100 Cornelia Huck wrote: On Thu, 16 Nov 2017 18:51:50 +0100 Pierre Morel wrote: @@ -493,9 +494,13 @@ int pcistg_service_call(S390CPU *cpu, uint8_t r1, uint8_t r2) break; } -data = env->regs[r1]

Re: [Qemu-devel] [PATCH v2 2/7] s390x/pci: rework PCI STORE

2017-11-21 Thread Pierre Morel
On 21/11/2017 11:38, Cornelia Huck wrote: On Thu, 16 Nov 2017 18:51:50 +0100 Pierre Morel wrote: Enhance the fault detection, correction of the fault reporting. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao Signed-off-by: Pierre Morel Same double s-o-b. removed. Thanks ---

Re: [Qemu-devel] [PATCH v2 2/7] s390x/pci: rework PCI STORE

2017-11-21 Thread Cornelia Huck
On Tue, 21 Nov 2017 11:38:45 +0100 Cornelia Huck wrote: > On Thu, 16 Nov 2017 18:51:50 +0100 > Pierre Morel wrote: > > @@ -493,9 +494,13 @@ int pcistg_service_call(S390CPU *cpu, uint8_t r1, > > uint8_t r2) > > break; > > } > > > > -data = env->regs[r1]; > > -if (pcias <

Re: [Qemu-devel] [PATCH v2 2/7] s390x/pci: rework PCI STORE

2017-11-21 Thread Cornelia Huck
On Thu, 16 Nov 2017 18:51:50 +0100 Pierre Morel wrote: > Enhance the fault detection, correction of the fault reporting. > > Signed-off-by: Pierre Morel > Reviewed-by: Yi Min Zhao > Signed-off-by: Pierre Morel Same double s-o-b. > --- > hw/s390x/s390-pci-inst.c | 39 ++-

[Qemu-devel] [PATCH v2 2/7] s390x/pci: rework PCI STORE

2017-11-16 Thread Pierre Morel
Enhance the fault detection, correction of the fault reporting. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao Signed-off-by: Pierre Morel --- hw/s390x/s390-pci-inst.c | 39 ++- 1 file changed, 22 insertions(+), 17 deletions(-) diff --git a/hw/s390x/s