Re: [Qemu-devel] [PATCH v2 2/7] disas: QOMify target specific setup

2015-05-11 Thread Richard Henderson
On 05/09/2015 01:11 PM, Peter Crosthwaite wrote: > Add a QOM function hook for target-specific disassembly setup. This > allows removal of the #ifdeffery currently implementing target specific > disas setup from disas.c. > > Signed-off-by: Peter Crosthwaite > --- > disas.c | 24 +++

Re: [Qemu-devel] [PATCH v2 2/7] disas: QOMify target specific setup

2015-05-11 Thread Richard Henderson
On 05/11/2015 07:46 AM, Paolo Bonzini wrote: > > > On 09/05/2015 22:11, Peter Crosthwaite wrote: >> @@ -198,6 +199,8 @@ static int print_insn_od_target(bfd_vma pc, >> disassemble_info *info) >> void target_disas(FILE *out, CPUArchState *env, target_ulong code, >>target_ulong

Re: [Qemu-devel] [PATCH v2 2/7] disas: QOMify target specific setup

2015-05-11 Thread Paolo Bonzini
On 09/05/2015 22:11, Peter Crosthwaite wrote: > @@ -198,6 +199,8 @@ static int print_insn_od_target(bfd_vma pc, > disassemble_info *info) > void target_disas(FILE *out, CPUArchState *env, target_ulong code, >target_ulong size, int flags) > { > +CPUState *cpu = ENV_GET_C

[Qemu-devel] [PATCH v2 2/7] disas: QOMify target specific setup

2015-05-09 Thread Peter Crosthwaite
Add a QOM function hook for target-specific disassembly setup. This allows removal of the #ifdeffery currently implementing target specific disas setup from disas.c. Signed-off-by: Peter Crosthwaite --- disas.c | 24 include/qom/cpu.h | 4 2 files changed