Re: [Qemu-devel] [PATCH v2 2/6] qdev: reset qdev along with qdev tree

2010-12-20 Thread Markus Armbruster
Stefan Weil writes: > Am 20.12.2010 13:58, schrieb Markus Armbruster: >> Anthony Liguori writes: >> >>> On 12/17/2010 08:45 AM, Peter Maydell wrote: On 17 December 2010 00:24, Anthony Liguori wrote: > On 12/16/2010 05:48 PM, Michael S. Tsirkin wrote: > >> Ugh, I keep f

Re: [Qemu-devel] [PATCH v2 2/6] qdev: reset qdev along with qdev tree

2010-12-20 Thread Stefan Weil
Am 20.12.2010 13:58, schrieb Markus Armbruster: Anthony Liguori writes: On 12/17/2010 08:45 AM, Peter Maydell wrote: On 17 December 2010 00:24, Anthony Liguori wrote: On 12/16/2010 05:48 PM, Michael S. Tsirkin wrote: Ugh, I keep forgetting about the non-qdev systems. Maybe it's a good wa

Re: [Qemu-devel] [PATCH v2 2/6] qdev: reset qdev along with qdev tree

2010-12-20 Thread Markus Armbruster
Anthony Liguori writes: > On 12/17/2010 08:45 AM, Peter Maydell wrote: >> On 17 December 2010 00:24, Anthony Liguori >> wrote: >> >>> On 12/16/2010 05:48 PM, Michael S. Tsirkin wrote: >>> Ugh, I keep forgetting about the non-qdev systems. Maybe it's a good way to finally mak

Re: [Qemu-devel] [PATCH v2 2/6] qdev: reset qdev along with qdev tree

2010-12-19 Thread Michael S. Tsirkin
> Michael, my patch (which fixes the first regression / crash) > is needed, too. Please add it to your git queue. > > Stefan Could you pls review/test the pci branch of my tree? This should have all the necessary bits. -- Thanks, MST

Re: [Qemu-devel] [PATCH v2 2/6] qdev: reset qdev along with qdev tree

2010-12-18 Thread Stefan Weil
Am 17.12.2010 05:47, schrieb Isaku Yamahata: On Fri, Dec 17, 2010 at 01:29:42PM +0900, Isaku Yamahata wrote: On Thu, Dec 16, 2010 at 08:31:21PM +0100, Stefan Weil wrote: The second regression also occurs with MIPS malta. Networking no longer works with the default pcnet nic. This is caused bec

Re: [Qemu-devel] [PATCH v2 2/6] qdev: reset qdev along with qdev tree

2010-12-17 Thread Anthony Liguori
On 12/17/2010 08:45 AM, Peter Maydell wrote: On 17 December 2010 00:24, Anthony Liguori wrote: On 12/16/2010 05:48 PM, Michael S. Tsirkin wrote: Ugh, I keep forgetting about the non-qdev systems. Maybe it's a good way to finally make everyone to convert? If a system maintainer can't

Re: [Qemu-devel] [PATCH v2 2/6] qdev: reset qdev along with qdev tree

2010-12-17 Thread Peter Maydell
On 17 December 2010 00:24, Anthony Liguori wrote: > On 12/16/2010 05:48 PM, Michael S. Tsirkin wrote: >> Ugh, I keep forgetting about the non-qdev systems. >> Maybe it's a good way to finally make everyone to convert? If a system >> maintainer can't be bothered to convert to qdev we can declare th

Re: [Qemu-devel] [PATCH v2 2/6] qdev: reset qdev along with qdev tree

2010-12-16 Thread Isaku Yamahata
On Fri, Dec 17, 2010 at 01:29:42PM +0900, Isaku Yamahata wrote: > On Thu, Dec 16, 2010 at 08:31:21PM +0100, Stefan Weil wrote: > > The second regression also occurs with MIPS malta. > > Networking no longer works with the default pcnet nic. > > > > This is caused because the reset function for pcne

Re: [Qemu-devel] [PATCH v2 2/6] qdev: reset qdev along with qdev tree

2010-12-16 Thread Isaku Yamahata
On Thu, Dec 16, 2010 at 08:31:21PM +0100, Stefan Weil wrote: > The second regression also occurs with MIPS malta. > Networking no longer works with the default pcnet nic. > > This is caused because the reset function for pcnet is no > longer called during system boot. The result in an invalid > mac

Re: [Qemu-devel] [PATCH v2 2/6] qdev: reset qdev along with qdev tree

2010-12-16 Thread Anthony Liguori
On 12/16/2010 05:48 PM, Michael S. Tsirkin wrote: On Thu, Dec 16, 2010 at 08:31:21PM +0100, Stefan Weil wrote: Am 19.11.2010 10:55, schrieb Isaku Yamahata: From: Anthony Liguori This patch changes the reset handling so that qdev has no knowledge of the global system reset. Instead, a

Re: [Qemu-devel] [PATCH v2 2/6] qdev: reset qdev along with qdev tree

2010-12-16 Thread Michael S. Tsirkin
On Thu, Dec 16, 2010 at 08:31:21PM +0100, Stefan Weil wrote: > Am 19.11.2010 10:55, schrieb Isaku Yamahata: > >From: Anthony Liguori > > > >This patch changes the reset handling so that qdev has no knowledge of the > >global system reset. Instead, a new bus/device level function is > >introduced >

Re: [Qemu-devel] [PATCH v2 2/6] qdev: reset qdev along with qdev tree

2010-12-16 Thread Stefan Weil
Am 19.11.2010 10:55, schrieb Isaku Yamahata: From: Anthony Liguori This patch changes the reset handling so that qdev has no knowledge of the global system reset. Instead, a new bus/device level function is introduced that allows all devices/buses on the bus/device to be reset using a depth f

[Qemu-devel] [PATCH v2 2/6] qdev: reset qdev along with qdev tree

2010-11-19 Thread Isaku Yamahata
From: Anthony Liguori This patch changes the reset handling so that qdev has no knowledge of the global system reset. Instead, a new bus/device level function is introduced that allows all devices/buses on the bus/device to be reset using a depth first transversal. N.B. we have to expose the im