Re: [Qemu-devel] [PATCH v2 2/6] qapi: add name parameter to nbd-server-add

2018-01-10 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 12/08/2017 11:33 AM, Dr. David Alan Gilbert wrote: > > >> @@ -2223,7 +2224,7 @@ void hmp_nbd_server_add(Monitor *mon, const QDict > >> *qdict) > >> bool writable = qdict_get_try_bool(qdict, "writable", false); > >> Error *local_err = NULL; >

Re: [Qemu-devel] [PATCH v2 2/6] qapi: add name parameter to nbd-server-add

2018-01-09 Thread Eric Blake
On 12/08/2017 11:33 AM, Dr. David Alan Gilbert wrote: >> @@ -2223,7 +2224,7 @@ void hmp_nbd_server_add(Monitor *mon, const QDict >> *qdict) >> bool writable = qdict_get_try_bool(qdict, "writable", false); >> Error *local_err = NULL; >> >> -qmp_nbd_server_add(device, true, writable

Re: [Qemu-devel] [PATCH v2 2/6] qapi: add name parameter to nbd-server-add

2018-01-09 Thread Eric Blake
On 12/07/2017 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: > Allow user to specify name for new export, to not reuse internal > node name and to not show it to clients. > > This also allows creating several exports per device. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/block.

Re: [Qemu-devel] [PATCH v2 2/6] qapi: add name parameter to nbd-server-add

2017-12-09 Thread Vladimir Sementsov-Ogievskiy
08.12.2017 20:33, Dr. David Alan Gilbert wrote: * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: Allow user to specify name for new export, to not reuse internal node name and to not show it to clients. This also allows creating several exports per device. Signed-off-by: Vladim

Re: [Qemu-devel] [PATCH v2 2/6] qapi: add name parameter to nbd-server-add

2017-12-08 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > Allow user to specify name for new export, to not reuse internal > node name and to not show it to clients. > > This also allows creating several exports per device. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/b

[Qemu-devel] [PATCH v2 2/6] qapi: add name parameter to nbd-server-add

2017-12-07 Thread Vladimir Sementsov-Ogievskiy
Allow user to specify name for new export, to not reuse internal node name and to not show it to clients. This also allows creating several exports per device. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block.json | 9 +++-- blockdev-nbd.c | 14 +- hmp.c |