Re: [Qemu-devel] [PATCH v2 2/5] Fix migration in case of scsi-generic

2015-05-14 Thread Paolo Bonzini
On 14/05/2015 13:02, Dimitris Aragiorgis wrote: > Also note that QEMU seems to flush the disk cache explicitly in > case of iSCSI, using iscsi_synchronizecache10_task() from libiscsi > inside iscsi_co_flush(). Right, QEMU does that if type is DISK only. > Perhaps we can also extend this approac

Re: [Qemu-devel] [PATCH v2 2/5] Fix migration in case of scsi-generic

2015-05-14 Thread Dimitris Aragiorgis
Hello Kevin, * Kevin Wolf [2015-05-11 12:12:23 +0200]: > Am 08.05.2015 um 19:47 hat Dimitris Aragiorgis geschrieben: > > During migration, QEMU uses fsync()/fdatasync() on the open file > > descriptor for read-write block devices to flush data just before > > stopping the VM. > > > > However, f

Re: [Qemu-devel] [PATCH v2 2/5] Fix migration in case of scsi-generic

2015-05-11 Thread Kevin Wolf
Am 08.05.2015 um 19:47 hat Dimitris Aragiorgis geschrieben: > During migration, QEMU uses fsync()/fdatasync() on the open file > descriptor for read-write block devices to flush data just before > stopping the VM. > > However, fsync() on a scsi-generic device returns -EINVAL which > causes the mig

[Qemu-devel] [PATCH v2 2/5] Fix migration in case of scsi-generic

2015-05-08 Thread Dimitris Aragiorgis
During migration, QEMU uses fsync()/fdatasync() on the open file descriptor for read-write block devices to flush data just before stopping the VM. However, fsync() on a scsi-generic device returns -EINVAL which causes the migration to fail. This patch skips flushing data in case of an SG device,