Re: [Qemu-devel] [PATCH v2 2/4] qemu-iotests: s390x: fix test 051

2015-11-26 Thread tu bo
Hi Max: On 11/25/2015 11:41 PM, Max Reitz wrote: On 24.11.2015 22:17, Sascha Silbe wrote: This PC/s390x-only hunk looks like an oversight to me. Not really, see http://lists.nongnu.org/archive/html/qemu-devel/2015-02/msg01906.html and http://lists.nongnu.org/archive/html/qemu-devel/2015-04/ms

Re: [Qemu-devel] [PATCH v2 2/4] qemu-iotests: s390x: fix test 051

2015-11-25 Thread Max Reitz
On 24.11.2015 22:17, Sascha Silbe wrote: > Dear Max, Hi! :-) > Max Reitz writes: > >> OK, so it is expected for s390x; however, this is strictly speaking not >> the output file for s390x but for any platform but PC. That's why I'd >> rather not have it in this “generic” reference output. >> >>

Re: [Qemu-devel] [PATCH v2 2/4] qemu-iotests: s390x: fix test 051

2015-11-24 Thread Sascha Silbe
Dear Max, Max Reitz writes: > OK, so it is expected for s390x; however, this is strictly speaking not > the output file for s390x but for any platform but PC. That's why I'd > rather not have it in this “generic” reference output. > > This patch already assumes that the iotests only support s390

Re: [Qemu-devel] [PATCH v2 2/4] qemu-iotests: s390x: fix test 051

2015-11-22 Thread tu bo
Hi Max, Sascha: On 11/21/2015 12:24 AM, Max Reitz wrote: On 19.11.2015 08:28, tu bo wrote: Hi Max: On 11/19/2015 12:52 AM, Max Reitz wrote: On 04.11.2015 03:26, Bo Tu wrote: The tests for device type "ide_cd" should only be tested for the pc platform. The default device id of hard disk on th

Re: [Qemu-devel] [PATCH v2 2/4] qemu-iotests: s390x: fix test 051

2015-11-20 Thread Max Reitz
On 19.11.2015 08:28, tu bo wrote: > Hi Max: > > On 11/19/2015 12:52 AM, Max Reitz wrote: >> On 04.11.2015 03:26, Bo Tu wrote: >>> The tests for device type "ide_cd" should only be tested for the pc >>> platform. >>> The default device id of hard disk on the s390 platform differs to that >>> of the

Re: [Qemu-devel] [PATCH v2 2/4] qemu-iotests: s390x: fix test 051

2015-11-18 Thread tu bo
Hi Max: On 11/19/2015 12:52 AM, Max Reitz wrote: On 04.11.2015 03:26, Bo Tu wrote: The tests for device type "ide_cd" should only be tested for the pc platform. The default device id of hard disk on the s390 platform differs to that of the x86 platform. A new variable device_id is defined and "

Re: [Qemu-devel] [PATCH v2 2/4] qemu-iotests: s390x: fix test 051

2015-11-18 Thread Max Reitz
On 04.11.2015 03:26, Bo Tu wrote: > The tests for device type "ide_cd" should only be tested for the pc > platform. > The default device id of hard disk on the s390 platform differs to that > of the x86 platform. A new variable device_id is defined and "virtio0" > set for the s390 platform. A x86 p

[Qemu-devel] [PATCH v2 2/4] qemu-iotests: s390x: fix test 051

2015-11-03 Thread Bo Tu
The tests for device type "ide_cd" should only be tested for the pc platform. The default device id of hard disk on the s390 platform differs to that of the x86 platform. A new variable device_id is defined and "virtio0" set for the s390 platform. A x86 platform specific output file is also needed.