On 24 June 2015 at 18:16, Andreas Färber wrote:
> Guys, is there any target that does not implement set_pc today? If so,
> which? I'd rather implement it than carry around the iffery and
> resulting complications.
No, there are none, see my analysis in my review of patch 1 in this set.
-- PMM
On Wed, Jun 24, 2015 at 10:16 AM, Andreas Färber wrote:
> Am 24.06.2015 um 19:04 schrieb Peter Crosthwaite:
>> On Wed, Jun 24, 2015 at 3:01 AM, Peter Maydell
>> wrote:
>>> On 24 June 2015 at 03:50, Peter Crosthwaite
>>> wrote:
On Mon, Jun 22, 2015 at 10:31 AM, Andreas Färber wrote:
>
Am 24.06.2015 um 19:04 schrieb Peter Crosthwaite:
> On Wed, Jun 24, 2015 at 3:01 AM, Peter Maydell
> wrote:
>> On 24 June 2015 at 03:50, Peter Crosthwaite
>> wrote:
>>> On Mon, Jun 22, 2015 at 10:31 AM, Andreas Färber wrote:
I believe this argument will probably go away; otherwise this sho
On Wed, Jun 24, 2015 at 3:01 AM, Peter Maydell wrote:
> On 24 June 2015 at 03:50, Peter Crosthwaite
> wrote:
>> On Mon, Jun 22, 2015 at 10:31 AM, Andreas Färber wrote:
>>> I believe this argument will probably go away; otherwise this should've
>>> been &error_abort or something instead of NULL.
On 24 June 2015 at 03:50, Peter Crosthwaite
wrote:
> On Mon, Jun 22, 2015 at 10:31 AM, Andreas Färber wrote:
>> I believe this argument will probably go away; otherwise this should've
>> been &error_abort or something instead of NULL.
>>
>
> I'm not sure. As I don't see what is catching the case
On Mon, Jun 22, 2015 at 10:31 AM, Andreas Färber wrote:
> Am 16.06.2015 um 07:46 schrieb Peter Crosthwaite:
>> Use the cpu_set_pc helper which will take care of CPUClass retrieval
>> for us.
>>
>> Signed-off-by: Peter Crosthwaite
>> ---
>> gdbstub.c | 5 +
>> 1 file changed, 1 insertion(+),
Am 16.06.2015 um 07:46 schrieb Peter Crosthwaite:
> Use the cpu_set_pc helper which will take care of CPUClass retrieval
> for us.
>
> Signed-off-by: Peter Crosthwaite
> ---
> gdbstub.c | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 75
Use the cpu_set_pc helper which will take care of CPUClass retrieval
for us.
Signed-off-by: Peter Crosthwaite
---
gdbstub.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index 75563db..ceb60ac 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -754,12 +754,