Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-28 Thread 赵小强
于 11/29/2013 11:48 AM, Andreas Färber 写道: Am 29.11.2013 02:26, schrieb 赵小强: 于 11/12/2013 10:52 PM, Andreas Färber 写道: it would be nice if you could check whether these devices (the non-KVM versions at least) are covered by make check. For ICC bus I am certain that it is. 1. Does "make check

Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-28 Thread 赵小强
于 11/29/2013 11:48 AM, Andreas Färber 写道: Am 29.11.2013 02:26, schrieb 赵小强: 于 11/12/2013 10:52 PM, Andreas Färber 写道: it would be nice if you could check whether these devices (the non-KVM versions at least) are covered by make check. For ICC bus I am certain that it is. 1. Does "make check

Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-28 Thread Andreas Färber
Am 29.11.2013 02:26, schrieb 赵小强: > 于 11/12/2013 10:52 PM, Andreas Färber 写道: >> it would be nice if you could check whether these >> devices (the non-KVM versions at least) are covered by make check. For >> ICC bus I am certain that it is. > 1. Does "make check" mean the build target in the Mak

Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-28 Thread 赵小强
于 11/13/2013 02:06 PM, 赵小强 写道: 于 11/12/2013 10:52 PM, Andreas Färber 写道: Resending yesterday's message since it hasn't arrived on qemu-devel... Am 11.11.2013 04:58, schrieb 赵小强: 于 11/05/2013 04:51 PM, 赵小强 写道: 于 2013年11月05日 16:25, Chen Fan 写道: On Tue, 2013-11-05 at 15:55 +0800, xiaoqiang zhao

Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-13 Thread Chen Fan
On Tue, 2013-11-12 at 17:41 +0100, Andreas Färber wrote: > Am 12.11.2013 04:02, schrieb Chen Fan: > > On Tue, 2013-11-12 at 09:54 +0800, 赵小强 wrote: > >> He asked me to drop the parent_realize. so in v2, I just replace the > >> 'init' with 'realize'. > >> > > Hmm,I'm confused, Go through the entire

Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-12 Thread 赵小强
于 11/12/2013 10:52 PM, Andreas Färber 写道: Resending yesterday's message since it hasn't arrived on qemu-devel... Am 11.11.2013 04:58, schrieb 赵小强: 于 11/05/2013 04:51 PM, 赵小强 写道: 于 2013年11月05日 16:25, Chen Fan 写道: On Tue, 2013-11-05 at 15:55 +0800, xiaoqiang zhao wrote: [...] diff --git a/inc

Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-12 Thread Andreas Färber
Am 12.11.2013 04:02, schrieb Chen Fan: > On Tue, 2013-11-12 at 09:54 +0800, 赵小强 wrote: >> He asked me to drop the parent_realize. so in v2, I just replace the >> 'init' with 'realize'. >> > Hmm,I'm confused, Go through the entire QEMU source code, there was no > DeviceRealize realize field in leaf

Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-12 Thread Andreas Färber
Hi, Am 12.11.2013 02:28, schrieb Chen Fan: > [...] not long ago, I had sent a path about refactor > apic, though, there was not commented, if you are interested in it, > please help to review it: > https://lists.gnu.org/archive/html/qemu-devel/2013-10/msg02823.html You sent your series on Oct 22n

Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-12 Thread Andreas Färber
Resending yesterday's message since it hasn't arrived on qemu-devel... Am 11.11.2013 04:58, schrieb 赵小强: > 于 11/05/2013 04:51 PM, 赵小强 写道: >> 于 2013年11月05日 16:25, Chen Fan 写道: >>> On Tue, 2013-11-05 at 15:55 +0800, xiaoqiang zhao wrote: [...] diff --git a/include/hw/cpu/icc_bus.h b/include/hw/

Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-11 Thread 赵小强
于 11/12/2013 11:02 AM, Chen Fan 写道: On Tue, 2013-11-12 at 09:54 +0800, 赵小强 wrote: 于 11/12/2013 09:28 AM, Chen Fan 写道: On Mon, 2013-11-11 at 11:58 +0800, 赵小强 wrote: 于 11/05/2013 04:51 PM, 赵小强 写道: 于 2013年11月05日 16:25, Chen Fan 写道: On Tue, 2013-11-05 at 15:55 +0800, xiaoqiang zhao wrote: chan

Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-11 Thread Chen Fan
On Tue, 2013-11-12 at 09:54 +0800, 赵小强 wrote: > 于 11/12/2013 09:28 AM, Chen Fan 写道: > > > On Mon, 2013-11-11 at 11:58 +0800, 赵小强 wrote: > > > 于 11/05/2013 04:51 PM, 赵小强 写道: > > > > 于 2013年11月05日 16:25, Chen Fan 写道: > > > > > On Tue, 2013-11-05 at 15:55 +0800, xiaoqiang zhao wrote: > > > > > > chan

Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-11 Thread 赵小强
于 11/12/2013 09:28 AM, Chen Fan 写道: On Mon, 2013-11-11 at 11:58 +0800, 赵小强 wrote: 于 11/05/2013 04:51 PM, 赵小强 写道: 于 2013年11月05日 16:25, Chen Fan 写道: On Tue, 2013-11-05 at 15:55 +0800, xiaoqiang zhao wrote: changes includes: 1. use type constant for apic and kvm_apic 2. convert function 'init' t

Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-11 Thread Chen Fan
On Mon, 2013-11-11 at 11:58 +0800, 赵小强 wrote: > 于 11/05/2013 04:51 PM, 赵小强 写道: > > 于 2013年11月05日 16:25, Chen Fan 写道: > >> On Tue, 2013-11-05 at 15:55 +0800, xiaoqiang zhao wrote: > >>> changes includes: > >>> 1. use type constant for apic and kvm_apic > >>> 2. convert function 'init' to QOM's 'real

Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-10 Thread 赵小强
于 11/05/2013 04:51 PM, 赵小强 写道: 于 2013年11月05日 16:25, Chen Fan 写道: On Tue, 2013-11-05 at 15:55 +0800, xiaoqiang zhao wrote: changes includes: 1. use type constant for apic and kvm_apic 2. convert function 'init' to QOM's 'realize' for apic/kvm_apic 3. for consistency, also QOM'ify apic's parent b

Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-05 Thread 赵小强
于 2013年11月05日 16:25, Chen Fan 写道: On Tue, 2013-11-05 at 15:55 +0800, xiaoqiang zhao wrote: changes includes: 1. use type constant for apic and kvm_apic 2. convert function 'init' to QOM's 'realize' for apic/kvm_apic 3. for consistency, also QOM'ify apic's parent bus 'icc_bus' --- hw/cpu/icc_bu

Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-05 Thread Chen Fan
On Tue, 2013-11-05 at 15:55 +0800, xiaoqiang zhao wrote: > changes includes: > 1. use type constant for apic and kvm_apic > 2. convert function 'init' to QOM's 'realize' for apic/kvm_apic > 3. for consistency, also QOM'ify apic's parent bus 'icc_bus' > --- > hw/cpu/icc_bus.c| 14

[Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-05 Thread xiaoqiang zhao
changes includes: 1. use type constant for apic and kvm_apic 2. convert function 'init' to QOM's 'realize' for apic/kvm_apic 3. for consistency, also QOM'ify apic's parent bus 'icc_bus' Signed-off-by: xiaoqiang zhao --- hw/cpu/icc_bus.c| 14 ++ hw/i386/kvm/apic.c

[Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-05 Thread xiaoqiang zhao
changes includes: 1. use type constant for apic and kvm_apic 2. convert function 'init' to QOM's 'realize' for apic/kvm_apic 3. for consistency, also QOM'ify apic's parent bus 'icc_bus' --- hw/cpu/icc_bus.c| 14 ++ hw/i386/kvm/apic.c | 10 +++--- hw

[Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-04 Thread xiaoqiang zhao
changes includes: 1. use type constant for apic and kvm_apic 2. convert function 'init' to QOM's 'realize' for apic/kvm_apic 3. for consistency, also QOM'ify apic's parent bus 'icc_bus' --- hw/cpu/icc_bus.c| 14 ++ hw/i386/kvm/apic.c | 10 +++--- hw