Re: [Qemu-devel] [PATCH v2 2/3] qemu-iotests: remove unused variable here

2018-11-16 Thread Eric Blake
On 10/24/18 6:26 PM, Philippe Mathieu-Daudé wrote: Hi Mao, On 24/10/18 11:40, Mao Zhongyi wrote: run git grep '\$here' tests/qemu-iotests Correct. You want both the \ and the $ to be handed to the grep regex. This command doesn't look correct, I believe you have to use either - git grep '

Re: [Qemu-devel] [PATCH v2 2/3] qemu-iotests: remove unused variable here

2018-10-24 Thread Philippe Mathieu-Daudé
Hi Mao, On 24/10/18 11:40, Mao Zhongyi wrote: run git grep '\$here' tests/qemu-iotests This command doesn't look correct, I believe you have to use either - git grep '$here' or - git grep \$here has 0 hits, which means we are setting a variable that no use, so execute the following cmd to

[Qemu-devel] [PATCH v2 2/3] qemu-iotests: remove unused variable here

2018-10-24 Thread Mao Zhongyi
run git grep '\$here' tests/qemu-iotests has 0 hits, which means we are setting a variable that no use, so execute the following cmd to remove all of the 'here=...' lines as dead code. sed -i '/here=/d' $(git grep -l 'here=' tests/qemu-iotests) Cc: kw...@redhat.com Cc: mre...@redhat.com Cc: ebl.