Re: [Qemu-devel] [PATCH v2 2/3] applesmc: implement error status port

2017-04-07 Thread Philippe Mathieu-Daudé
On 04/04/2017 02:01 PM, Gabriel L. Somlo wrote: As of release 10.12.4, OS X (Sierra) refuses to boot unless the AppleSMC supports an additional I/O port, expected to provide an error status code. Update the [cmd|data]_write() and data_read() methods to implement the required state machine, and a

Re: [Qemu-devel] [PATCH v2 2/3] applesmc: implement error status port

2017-04-06 Thread Phil Dennis-Jordan
I can confirm this solves the boot-time kernel panic on macOS 10.12.4 guests. No apparent regressions for earlier OS versions I tested, either. Code looks sane to me. I guess the only thing is I assume this was backed by some kind of investigation into what the real hardware does. If that investiga

[Qemu-devel] [PATCH v2 2/3] applesmc: implement error status port

2017-04-04 Thread Gabriel L. Somlo
As of release 10.12.4, OS X (Sierra) refuses to boot unless the AppleSMC supports an additional I/O port, expected to provide an error status code. Update the [cmd|data]_write() and data_read() methods to implement the required state machine, and add I/O region & methods to handle access to the er