Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-08-01 Thread Paolo Bonzini
> KVM disabled HW counters when outside of a guest mode (otherwise result > will be useless), so I do not see how the problem you describe can > happen. Yes, you're right. > On the other hand MPU emulation assumes that counter have to be disabled > while MSR_IA32_PERFCTR0 is written since write t

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-08-01 Thread Gleb Natapov
On Thu, Aug 01, 2013 at 03:48:29PM +0200, Paolo Bonzini wrote: > On Aug 01 2013, Gleb Natapov wrote: > > On Thu, Aug 01, 2013 at 03:03:12PM +0200, Paolo Bonzini wrote: > > > > KVM disabled HW counters when outside of a guest mode (otherwise result > > > > will be useless), so I do not see how the

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-08-01 Thread Paolo Bonzini
On Aug 01 2013, Gleb Natapov wrote: > On Thu, Aug 01, 2013 at 03:03:12PM +0200, Paolo Bonzini wrote: > > > KVM disabled HW counters when outside of a guest mode (otherwise result > > > will be useless), so I do not see how the problem you describe can > > > happen. > > > > Yes, you're right. > >

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-08-01 Thread Gleb Natapov
On Thu, Aug 01, 2013 at 03:03:12PM +0200, Paolo Bonzini wrote: > > KVM disabled HW counters when outside of a guest mode (otherwise result > > will be useless), so I do not see how the problem you describe can > > happen. > > Yes, you're right. > > > On the other hand MPU emulation assumes that c

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-07-28 Thread Gleb Natapov
On Sun, Jul 28, 2013 at 04:07:37PM +0200, Paolo Bonzini wrote: > Il 28/07/2013 15:54, Gleb Natapov ha scritto: > > On Sun, Jul 28, 2013 at 03:51:25PM +0200, Paolo Bonzini wrote: > >> Il 28/07/2013 14:57, Gleb Natapov ha scritto: > @@ -1114,6 +1135,33 @@ static int kvm_put_msrs(X86CPU *cpu, int

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-07-28 Thread Paolo Bonzini
Il 28/07/2013 15:54, Gleb Natapov ha scritto: > On Sun, Jul 28, 2013 at 03:51:25PM +0200, Paolo Bonzini wrote: >> Il 28/07/2013 14:57, Gleb Natapov ha scritto: @@ -1114,6 +1135,33 @@ static int kvm_put_msrs(X86CPU *cpu, int level) kvm_msr_entry_set(&msrs[n++], MSR_KVM_STEAL_T

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-07-28 Thread Gleb Natapov
On Sun, Jul 28, 2013 at 03:51:25PM +0200, Paolo Bonzini wrote: > Il 28/07/2013 14:57, Gleb Natapov ha scritto: > >> @@ -1114,6 +1135,33 @@ static int kvm_put_msrs(X86CPU *cpu, int level) > >> kvm_msr_entry_set(&msrs[n++], MSR_KVM_STEAL_TIME, > >>env->ste

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-07-28 Thread Paolo Bonzini
Il 28/07/2013 14:57, Gleb Natapov ha scritto: >> @@ -1114,6 +1135,33 @@ static int kvm_put_msrs(X86CPU *cpu, int level) >> kvm_msr_entry_set(&msrs[n++], MSR_KVM_STEAL_TIME, >>env->steal_time_msr); >> } >> +if (has_msr_architectural_pmu)

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-07-28 Thread Gleb Natapov
On Thu, Jul 25, 2013 at 05:05:22PM +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > target-i386/cpu.h | 23 + > target-i386/kvm.c | 93 > --- > target-i386/machine.c | 44 > 3 files cha

[Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-07-25 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- target-i386/cpu.h | 23 + target-i386/kvm.c | 93 --- target-i386/machine.c | 44 3 files changed, 155 insertions(+), 5 deletions(-) diff --git a/target-i386/cpu.h b/targ