Re: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-07-04 Thread Peter Xu
On Thu, Jul 04, 2019 at 01:45:41PM +0800, Jason Wang wrote: > > On 2019/6/24 下午5:18, Peter Xu wrote: > > This is an replacement work of Yan Zhao's patch: > > > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg625340.html > > > > vtd_address_space_unmap() will do proper page mask alignment

Re: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-07-03 Thread Jason Wang
On 2019/6/24 下午5:18, Peter Xu wrote: This is an replacement work of Yan Zhao's patch: https://www.mail-archive.com/qemu-devel@nongnu.org/msg625340.html vtd_address_space_unmap() will do proper page mask alignment to make sure each IOTLB message will have correct masks for notification message

Re: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-25 Thread Auger Eric
Hi Peter, On 6/24/19 11:18 AM, Peter Xu wrote: > This is an replacement work of Yan Zhao's patch: > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg625340.html > > vtd_address_space_unmap() will do proper page mask alignment to make > sure each IOTLB message will have correct masks for n

Re: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Yan Zhao
Tested-by: Yan Zhao On Mon, Jun 24, 2019 at 05:18:11PM +0800, Peter Xu wrote: > This is an replacement work of Yan Zhao's patch: > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg625340.html > > vtd_address_space_unmap() will do proper page mask alignment to make > sure each IOTLB messa

Re: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Paolo Bonzini
On 24/06/19 14:48, Auger Eric wrote: +if (alignment <= size) { +/* Increase the alignment of start */ >>> I don't really get this comment >> This comment comes from Paolo, but I'll try to explain - it tries to >> mean that this "alignment" will be used as an increasement to "s

Re: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Auger Eric
On 6/24/19 1:10 PM, Peter Xu wrote: > On Mon, Jun 24, 2019 at 12:09:48PM +0200, Auger Eric wrote: >> Hi Peter, >> >> On 6/24/19 11:18 AM, Peter Xu wrote: >>> This is an replacement work of Yan Zhao's patch: >>> >>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg625340.html >>> >>> vtd_add

Re: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Peter Xu
On Mon, Jun 24, 2019 at 12:09:48PM +0200, Auger Eric wrote: > Hi Peter, > > On 6/24/19 11:18 AM, Peter Xu wrote: > > This is an replacement work of Yan Zhao's patch: > > > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg625340.html > > > > vtd_address_space_unmap() will do proper page ma

Re: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Paolo Bonzini
On 24/06/19 11:18, Peter Xu wrote: > This is an replacement work of Yan Zhao's patch: > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg625340.html > > vtd_address_space_unmap() will do proper page mask alignment to make > sure each IOTLB message will have correct masks for notification >

Re: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Auger Eric
Hi Peter, On 6/24/19 11:18 AM, Peter Xu wrote: > This is an replacement work of Yan Zhao's patch: > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg625340.html > > vtd_address_space_unmap() will do proper page mask alignment to make > sure each IOTLB message will have correct masks for n

[Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Peter Xu
This is an replacement work of Yan Zhao's patch: https://www.mail-archive.com/qemu-devel@nongnu.org/msg625340.html vtd_address_space_unmap() will do proper page mask alignment to make sure each IOTLB message will have correct masks for notification messages (2^N-1), but sometimes it can be expand