Re: [Qemu-devel] [PATCH v2 2/2] hw/vfio/display: add ramfb support

2018-10-12 Thread Alex Williamson
On Fri, 12 Oct 2018 10:43:02 +0200 Gerd Hoffmann wrote: > Hi, > > > > OnOffAuto display; > > > +bool enable_ramfb; > > > int32_t bootindex; > > > uint32_t igd_gms; > > > OffAutoPCIBAR msix_relo; > > > > Hi Gerd, > > > > One tiny nit here, we can move this new bool d

Re: [Qemu-devel] [PATCH v2 2/2] hw/vfio/display: add ramfb support

2018-10-12 Thread Gerd Hoffmann
Hi, > > OnOffAuto display; > > +bool enable_ramfb; > > int32_t bootindex; > > uint32_t igd_gms; > > OffAutoPCIBAR msix_relo; > > Hi Gerd, > > One tiny nit here, we can move this new bool down in the struct with > the rest of the bools for better alignment. I can change

Re: [Qemu-devel] [PATCH v2 2/2] hw/vfio/display: add ramfb support

2018-10-11 Thread Alex Williamson
On Mon, 17 Sep 2018 08:17:29 +0200 Gerd Hoffmann wrote: > So we have a boot display when using a vgpu as primary display. > > ramfb depends on a fw_cfg file. fw_cfg files can not be added and > removed at runtime, therefore a ramfb-enabled vfio device can't be > hotplugged. > > Add a nohotplug

[Qemu-devel] [PATCH v2 2/2] hw/vfio/display: add ramfb support

2018-09-16 Thread Gerd Hoffmann
So we have a boot display when using a vgpu as primary display. ramfb depends on a fw_cfg file. fw_cfg files can not be added and removed at runtime, therefore a ramfb-enabled vfio device can't be hotplugged. Add a nohotplug variant of the vfio-pci device (as child class). Add the ramfb propert