Re: [Qemu-devel] [PATCH v2 2/2] Add AT24Cxx I2C EEPROM device model

2013-04-29 Thread Jan Kiszka
On 2013-02-23 14:40, Andreas Färber wrote: >> +static int at24_init(I2CSlave *i2c) > > hw/i2c.c:i2c_slave_qdev_init() calls I2CSlaveClass::init only, so please > use a realize function instead. Cf. hw/qdev-core.h. > >> +{ >> +AT24State *s = DO_UPCAST(AT24State, i2c, i2c); >> +unsigned int

Re: [Qemu-devel] [PATCH v2 2/2] Add AT24Cxx I2C EEPROM device model

2013-02-27 Thread Jan Kiszka
On 2013-02-27 05:44, Peter Crosthwaite wrote: > Hi Jan, > > I actually have my own subset implementation of this currently on > list. Yours is more complete however, So id prefer to drop mine in > favour of yours and reverify Zynq as working with yours. Great! I'm trying to look for a slot to add

Re: [Qemu-devel] [PATCH v2 2/2] Add AT24Cxx I2C EEPROM device model

2013-02-26 Thread Peter Crosthwaite
Hi Jan, I actually have my own subset implementation of this currently on list. Yours is more complete however, So id prefer to drop mine in favour of yours and reverify Zynq as working with yours. On Sat, Feb 23, 2013 at 6:39 AM, Jan Kiszka wrote: > This implements I2C EEPROMs of the AT24Cxx se

Re: [Qemu-devel] [PATCH v2 2/2] Add AT24Cxx I2C EEPROM device model

2013-02-25 Thread Andreas Färber
Am 25.02.2013 08:49, schrieb Paolo Bonzini: > >>> +#include "hw.h" >>> +#include "i2c.h" >> >> Please use "hw/hw.h" and "hw/i2c.h" since Paolo is planning to move >> I2C devices into hw/i2c/. > > No, I2C _masters_ move into hw/i2c. This would probably move into > hw/nvram. OK, but my point of u

Re: [Qemu-devel] [PATCH v2 2/2] Add AT24Cxx I2C EEPROM device model

2013-02-24 Thread Paolo Bonzini
> > +#include "hw.h" > > +#include "i2c.h" > > Please use "hw/hw.h" and "hw/i2c.h" since Paolo is planning to move > I2C devices into hw/i2c/. No, I2C _masters_ move into hw/i2c. This would probably move into hw/nvram. Paolo > > +#include "sysemu/blockdev.h" > > +#include "hw/block-common.h"

Re: [Qemu-devel] [PATCH v2 2/2] Add AT24Cxx I2C EEPROM device model

2013-02-23 Thread Andreas Färber
Am 22.02.2013 21:39, schrieb Jan Kiszka: > This implements I2C EEPROMs of the AT24Cxx series. Sizes from 1Kbit to > 1024Kbit are supported. Each EEPROM is backed by a block device. Its > size can be explicitly specified by the "size" property (required for > sizes < 512, the blockdev sector size) o

[Qemu-devel] [PATCH v2 2/2] Add AT24Cxx I2C EEPROM device model

2013-02-22 Thread Jan Kiszka
This implements I2C EEPROMs of the AT24Cxx series. Sizes from 1Kbit to 1024Kbit are supported. Each EEPROM is backed by a block device. Its size can be explicitly specified by the "size" property (required for sizes < 512, the blockdev sector size) or is derived from the size of the backing block d