Re: [Qemu-devel] [PATCH v2 18/31] acpi: rename cpu_hotplug_defs.h to acpi_defs.h

2014-05-20 Thread Igor Mammedov
On Tue, 20 May 2014 18:35:33 +0300 "Michael S. Tsirkin" wrote: > On Tue, May 20, 2014 at 05:15:21PM +0200, Igor Mammedov wrote: > > to make it more generic, so it could be used for memory hotplug > > as well. > > > > Signed-off-by: Igor Mammedov > > These are actually qemu pc specific hotplug

Re: [Qemu-devel] [PATCH v2 18/31] acpi: rename cpu_hotplug_defs.h to acpi_defs.h

2014-05-20 Thread Michael S. Tsirkin
On Tue, May 20, 2014 at 05:15:21PM +0200, Igor Mammedov wrote: > to make it more generic, so it could be used for memory hotplug > as well. > > Signed-off-by: Igor Mammedov These are actually qemu pc specific hotplug registers, this name makes one think these are generic defines. How about ./inc

[Qemu-devel] [PATCH v2 18/31] acpi: rename cpu_hotplug_defs.h to acpi_defs.h

2014-05-20 Thread Igor Mammedov
to make it more generic, so it could be used for memory hotplug as well. Signed-off-by: Igor Mammedov --- hw/i386/acpi-dsdt.dsl |2 +- hw/i386/q35-acpi-dsdt.dsl |2 +- include/hw/acpi/acpi_defs.h| 33 + include/hw/acpi/cpu_h