Re: [Qemu-devel] [PATCH v2 16/45] scsi-disk: Track tray locked state

2011-08-04 Thread Hannes Reinecke
On 08/04/2011 09:25 AM, Markus Armbruster wrote: Hannes Reinecke writes: On 08/04/2011 08:39 AM, Markus Armbruster wrote: Hannes Reinecke writes: On 08/03/2011 03:07 PM, Markus Armbruster wrote: We already track it in BlockDriverState. Just like tray open/close state, we should track it

Re: [Qemu-devel] [PATCH v2 16/45] scsi-disk: Track tray locked state

2011-08-04 Thread Markus Armbruster
Hannes Reinecke writes: > On 08/04/2011 08:39 AM, Markus Armbruster wrote: >> Hannes Reinecke writes: >> >>> On 08/03/2011 03:07 PM, Markus Armbruster wrote: We already track it in BlockDriverState. Just like tray open/close state, we should track it in the device models instead, beca

Re: [Qemu-devel] [PATCH v2 16/45] scsi-disk: Track tray locked state

2011-08-03 Thread Hannes Reinecke
On 08/04/2011 08:39 AM, Markus Armbruster wrote: Hannes Reinecke writes: On 08/03/2011 03:07 PM, Markus Armbruster wrote: We already track it in BlockDriverState. Just like tray open/close state, we should track it in the device models instead, because it's device state. Signed-off-by: Mark

Re: [Qemu-devel] [PATCH v2 16/45] scsi-disk: Track tray locked state

2011-08-03 Thread Markus Armbruster
Hannes Reinecke writes: > On 08/03/2011 03:07 PM, Markus Armbruster wrote: >> We already track it in BlockDriverState. Just like tray open/close >> state, we should track it in the device models instead, because it's >> device state. >> >> Signed-off-by: Markus Armbruster >> --- >> hw/scsi-dis

Re: [Qemu-devel] [PATCH v2 16/45] scsi-disk: Track tray locked state

2011-08-03 Thread Hannes Reinecke
On 08/03/2011 03:07 PM, Markus Armbruster wrote: We already track it in BlockDriverState. Just like tray open/close state, we should track it in the device models instead, because it's device state. Signed-off-by: Markus Armbruster --- hw/scsi-disk.c |4 +++- 1 files changed, 3 insertion

[Qemu-devel] [PATCH v2 16/45] scsi-disk: Track tray locked state

2011-08-03 Thread Markus Armbruster
We already track it in BlockDriverState. Just like tray open/close state, we should track it in the device models instead, because it's device state. Signed-off-by: Markus Armbruster --- hw/scsi-disk.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/scsi-disk.c b/