Re: [Qemu-devel] [PATCH v2 16/28] s390x/tcg: Fault-safe memmove

2019-09-13 Thread David Hildenbrand
On 12.09.19 00:03, Richard Henderson wrote: > On 9/6/19 3:57 AM, David Hildenbrand wrote: >> +static void access_memmove_idx(CPUS390XState *env, vaddr dest, vaddr src, >> + int size, int dest_idx, int src_idx, >> + uintptr_t ra) >> +{ >> +

Re: [Qemu-devel] [PATCH v2 16/28] s390x/tcg: Fault-safe memmove

2019-09-11 Thread Richard Henderson
On 9/6/19 3:57 AM, David Hildenbrand wrote: > +static void access_memmove_idx(CPUS390XState *env, vaddr dest, vaddr src, > + int size, int dest_idx, int src_idx, > + uintptr_t ra) > +{ > +S390Access srca = access_prepare_idx(env, src,

Re: [Qemu-devel] [PATCH v2 16/28] s390x/tcg: Fault-safe memmove

2019-09-11 Thread Richard Henderson
On 9/6/19 3:57 AM, David Hildenbrand wrote: > Replace fast_memmove() variants by access_memmove() variants, that > first try to probe access to all affected pages (maximum is two pages). > > In MVCOS, simply always call access_memmove_as() and drop the TODO > about LAP. LAP is already handled in t

[Qemu-devel] [PATCH v2 16/28] s390x/tcg: Fault-safe memmove

2019-09-06 Thread David Hildenbrand
Replace fast_memmove() variants by access_memmove() variants, that first try to probe access to all affected pages (maximum is two pages). In MVCOS, simply always call access_memmove_as() and drop the TODO about LAP. LAP is already handled in the MMU. Get rid of adj_len_to_page(), which is now un