On 23/11/2015 16:59, Kevin Wolf wrote:
> +bs->explicit_options = qdict_clone_shallow(options);
qdict_clone_shallow dereferences options, and other parts of
bdrv_open_inherit assume options != NULL. You can remove the first part
of this condition, some 50 lines below:
/* Check if any un
On 23.11.2015 16:59, Kevin Wolf wrote:
> bs->options doesn't only contain options that the user explicitly
> requested, but also option that were derived from flags, the filename or
> inherited from the parent node.
>
> For reopen, it is important to know the difference because reopening the
> par
bs->options doesn't only contain options that the user explicitly
requested, but also option that were derived from flags, the filename or
inherited from the parent node.
For reopen, it is important to know the difference because reopening the
parent can change inherited values in child nodes, but