Re: [Qemu-devel] [PATCH v2 13/13] net: Introduce e1000e device emulation

Hi Jason, See below... > On 7 Apr 2016, at 10:24 AM, Jason Wang wrote: […] > +Device properties: + ++-++-+ +| Propery name | Description| Type | Default | ++---

Re: [Qemu-devel] [PATCH v2 13/13] net: Introduce e1000e device emulation

On 04/06/2016 04:22 PM, Dmitry Fleytman wrote: > Hi Jason, > > Please see my comments below. > >> On 8 Mar 2016, at 11:31 AM, Jason Wang > > wrote: >> >> >> >> On 02/23/2016 01:37 AM, Leonid Bloch wrote: >>> From: Dmitry Fleytman >>

Re: [Qemu-devel] [PATCH v2 13/13] net: Introduce e1000e device emulation

> On 6 Apr 2016, at 16:44 PM, Michael S. Tsirkin wrote: > > On Wed, Apr 06, 2016 at 04:42:57PM +0300, Dmitry Fleytman wrote: >> >>> On 6 Apr 2016, at 16:23 PM, Michael S. Tsirkin wrote: >>> >>> On Wed, Apr 06, 2016 at 11:22:24AM +0300, Dmitry Fleytman wrote: +MemoryRegion flash

Re: [Qemu-devel] [PATCH v2 13/13] net: Introduce e1000e device emulation

On Wed, Apr 06, 2016 at 04:42:57PM +0300, Dmitry Fleytman wrote: > > > On 6 Apr 2016, at 16:23 PM, Michael S. Tsirkin wrote: > > > > On Wed, Apr 06, 2016 at 11:22:24AM +0300, Dmitry Fleytman wrote: > >>+MemoryRegion flash; > >> > >> > >>Looks there's no real implementation for

Re: [Qemu-devel] [PATCH v2 13/13] net: Introduce e1000e device emulation

> On 6 Apr 2016, at 16:23 PM, Michael S. Tsirkin wrote: > > On Wed, Apr 06, 2016 at 11:22:24AM +0300, Dmitry Fleytman wrote: >>+MemoryRegion flash; >> >> >>Looks there's no real implementation for flash. So is this really needed >>(e.g did WHQL or other test check for this?

Re: [Qemu-devel] [PATCH v2 13/13] net: Introduce e1000e device emulation

On Wed, Apr 06, 2016 at 11:22:24AM +0300, Dmitry Fleytman wrote: > +MemoryRegion flash; > > > Looks there's no real implementation for flash. So is this really needed > (e.g did WHQL or other test check for this?). > > > From our experience some drivers may verify that devic